Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rubocop-performance gem and config to fix deprecation message #430

Merged
merged 2 commits into from Feb 20, 2020
Merged

Add rubocop-performance gem and config to fix deprecation message #430

merged 2 commits into from Feb 20, 2020

Conversation

oreoshake
Copy link
Contributor

@oreoshake oreoshake commented Feb 20, 2020 

Post-install message from rubocop:
Performance Cops will be removed from RuboCop 0.68. Use rubocop-performance gem instead.

Put this in your Gemfile.

  gem 'rubocop-performance'

And then execute:

  $ bundle install

Put this into your .rubocop.yml.

  require: rubocop-performance

oreoshake added 2 commits Feb 20, 2020
@oreoshake
Add rubocop-performance gem and config to fix deprecation message
d378215
@oreoshake
ehhh apparently the order of the gemfile matters?
b2cc950 
Gemfile:14:3: C: Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem rubocop-github should appear before rubocop-performance.
  gem "rubocop-github"
  ^^^^^^^^^^^^^^^^^^^^
@oreoshake oreoshake merged commit c3e47ee into master Feb 20, 2020
3 checks passed
@oreoshake oreoshake deleted the fix-rubocop-perf-warning branch Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@oreoshake