Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Welcome page customization and the behavior of Ctrl/Cmd+R #128661

Closed
scaomath opened this issue Jul 14, 2021 · 6 comments
Closed

Welcome page customization and the behavior of Ctrl/Cmd+R #128661

scaomath opened this issue Jul 14, 2021 · 6 comments

Comments

@scaomath
Copy link

@scaomath scaomath commented Jul 14, 2021

A longer recent list

Related: #106715, #83451

While I understand the vscode team is not pursuing in this direction (#30646, #63057), it would be really nice if the number of recent shown can be customized.

Especially for people using a screen with higher resolutions:

Screenshot from 2021-07-14 09-19-48

Better Ctrl/Cmd + R behavior

I understand that this function is similar to Ctrl+R, then type the filename. However, upon opening a specific file, the workspace that file is under will NOT be automatically loaded:

Screenshot from 2021-07-14 09-42-33

For the example above, upon hitting enter, the workspace ft-experiment will not be loaded. Therefore I myself like to load the workspace first, then Ctrl+P, which makes the first simple change more attractive.

Reason behind

Working in scientific computing often deals with LaTeX, experimental code, production code, debugging happening in the same repo same branch. I myself often uses multiple workspaces to handle different "working spaces" (I also taught my student to do so...), which makes displaying more workspaces or folder in the welcome page a nice feature. Thoughts?

@bolu-tife
Copy link

@bolu-tife bolu-tife commented Jul 15, 2021

Hello @JacksonKearl I would like to work on this issue. Do you have any guide on how to reproduce this and what is required to be done?

@JacksonKearl
Copy link
Contributor

@JacksonKearl JacksonKearl commented Jul 15, 2021

@bolu-tife Sure!

To reproduce, set the max results setting to some larger value, and run a search in the search editor which has more results than the value:
image
image

Access search editor with:
image

You can start by changing the limit passed here to read from the configurationService

Then, you should add a way for the search to be re run with no limit. See what happens in the search from the sidebar, whose code is here: https://github.com/microsoft/vscode/blob/1fc68f3cf274141942b424894645a4f7096ec1f1/src/vs/workbench/contrib/search/browser/searchView.ts#L0-L1 for how to make that change.

@bolu-tife
Copy link

@bolu-tife bolu-tife commented Jul 16, 2021

Thank you

@dustinm76
Copy link

@dustinm76 dustinm76 commented Jul 31, 2021

@JacksonKearl I'm a bit confused about your suggested fix. It seems like the issue here was more about making the Recent list longer than getting a large number of results to show up in the search editor.

@JacksonKearl
Copy link
Contributor

@JacksonKearl JacksonKearl commented Aug 2, 2021

@dustinm76 sorry about that, I was thinking of #129153 for some reason. This requires a bit of design discussion so not really something that can be implemented at the moment.

@scaomath One alternative in this vein is the concept of "favoriting" workspaces, so instead of having a longer list of 10+ recent workspaces, you might have your 4 "Starred" workspaces at the top of the list, then 6 recent ones after that. Would that work for your use case?

@scaomath
Copy link
Author

@scaomath scaomath commented Aug 2, 2021

@scaomath One alternative in this vein is the concept of "favoriting" workspaces, so instead of having a longer list of 10+ recent workspaces, you might have your 4 "Starred" workspaces at the top of the list, then 6 recent ones after that. Would that work for your use case?

Personally I like this change a lot (especially for those us who have workspaces involving loading docker containers), but I doubt adding extra UI elements is what VSCode community want...

Guess I will wait for someone to implement an extension for this.

@scaomath scaomath closed this Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants