Skip to content

/ vue

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: move to typescript #12001

Open
wants to merge 21 commits into
base: dev
Choose a base branch
from
Open

chore: move to typescript #12001

wants to merge 21 commits into from
+95,473 −106,926

Conversation

@pikax
Copy link
Member

@pikax pikax commented Apr 3, 2021 •
edited

What kind of change does this PR introduce? (check at least one)

  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe: Typescript code base

Does this PR introduce a breaking change? (check one)

  • No

Other information:

Move the code base from flow to typescript

Plan

This PR plans to convert the current flow code into typescript and type some of the code, avoiding changes to javascript output code.

This PR will stay open for a while, there's many pending PR which need to be merged before this.

Status

  • convert all the js files to typescript
  • replace flow types with typescript
  • make build and CI work
  • introduce typing to plain JS files
@pikax
chore: move to typescript
af9fc2b
@pikax pikax self-assigned this Apr 3, 2021
pikax added 15 commits Apr 3, 2021
@pikax
fix build
65b683a
@pikax
import as types
63f9077
@pikax
fix unit tests
9c70fc0
@pikax
ignore folder
79f9e15
@pikax
bump rollup deps
cb0d18b
@pikax
replace flow with ts-check
54ee448
@pikax
remove @flow
0af78c5
@pikax
fix keepalive to ts
5f4763e
@pikax
changed to eslint and updated babel deps
6c86065
@pikax
eslint fixes
69a1bc9
@pikax
fix ts-check
b3de21c
@pikax
removed jasmine types
e643e44
@pikax
fix "he" dep thanks @sodatea
180474d
@pikax
fix test:weex
3fd8bb4
@pikax
Merge branch 'dev' into move_to_typescript
87afa06
@pikax pikax marked this pull request as ready for review Apr 7, 2021
@KaelWD
KaelWD reviewed Apr 7, 2021
View changes
typescript/modules.d.ts Outdated Show resolved Hide resolved
@KaelWD
KaelWD reviewed Apr 7, 2021
View changes
typescript/modules.d.ts Outdated Show resolved Hide resolved
pikax and others added 4 commits Apr 7, 2021
@pikax @KaelWD
Update typescript/modules.d.ts
00ef43b 
Co-authored-by: Kael <kaelwd@gmail.com>
@pikax
update terser and buble
52d3a7c
@pikax
remove custom modules and use the typescript ones
f036db5
@pikax
dedup functions
b5f39bf
@Kingwl Kingwl mentioned this pull request Apr 12, 2021
Closed
@wyx1818
Copy link

@wyx1818 wyx1818 commented Apr 12, 2021

膜拜大佬

@xiaohuahegege
Copy link

@xiaohuahegege xiaohuahegege commented Apr 13, 2021 •
edited

6666, Dai lo ! 😄 niubility.

@chenwuliang
Copy link

@chenwuliang chenwuliang commented Apr 13, 2021

神

@gcaaa31928
Copy link

@gcaaa31928 gcaaa31928 commented Apr 13, 2021

amazing PR

@pikax
chore: improve some types and remove @ts-ignore
f22b216
@ouliuquan
Copy link

@ouliuquan ouliuquan commented Apr 14, 2021

改到typescript没问题，能不能跟兄弟们商量下再发PR

@wangyjx
Copy link

@wangyjx wangyjx commented Apr 14, 2021

shocked, astonished, amazed, surprised, startled

@ifzm
Copy link

@ifzm ifzm commented Apr 14, 2021

Shock ! )
This is crazy, too powerful ... 👍

@pifeifei
Copy link

@pifeifei pifeifei commented Apr 14, 2021 •
edited

6666, 😄 niubility.

@NateLing
Copy link

@NateLing NateLing commented Apr 15, 2021

merge,plz

@tscsds
Copy link

@tscsds tscsds commented Apr 15, 2021

Merge it, quickly! It's sad it is still using the shitty "flow" what flows to nowhere.

@cereschen
Copy link

@cereschen cereschen commented Apr 15, 2021

Unfortunately, there is still a lot of work to be done to achieve the perfect TS, and who is going to do that part?😅

@tscsds
Copy link

@tscsds tscsds commented Apr 15, 2021

Unfortunately, there is still a lot of work to be done to achieve the perfect TS, and who is going to do that part?😅

It doesn't have to be "Perfect TS", just replacing the typing with TS is already enough, much better for reading the code.

@cereschen
Copy link

@cereschen cereschen commented Apr 15, 2021 •
edited

Unfortunately, there is still a lot of work to be done to achieve the perfect TS, and who is going to do that part?😅

It doesn't have to be "Perfect TS", just replacing the typing with TS is already enough, much better for reading the code.

I agree with you. At least it's better than before

@JdesEva
Copy link

@JdesEva JdesEva commented Apr 15, 2021

6666

@XinChou16
Copy link

@XinChou16 XinChou16 commented Apr 15, 2021

awesome👏

@posva posva mentioned this pull request Apr 26, 2021
Closed
@ytianzaishui
Copy link

@ytianzaishui ytianzaishui commented May 2, 2021

What a nice job!

@dinhquochan
Copy link

@dinhquochan dinhquochan commented May 5, 2021

Epic PR 🤯

@myluke
Copy link

@myluke myluke commented May 15, 2021

路过，看看这个牛逼的pr

@wellfrog16
Copy link

@wellfrog16 wellfrog16 commented May 16, 2021

历史性的PR，赶紧前排占个位置。

@GodLyons
Copy link

@GodLyons GodLyons commented May 20, 2021

这样的话vue代码的可读性将会提升n个台阶

@dargoner
Copy link

@dargoner dargoner commented Jun 1, 2021

膜拜

@nabaonan
Copy link

@nabaonan nabaonan commented Jul 21, 2021

膜拜大佬，不知会不会在2.7中发布，期待merge

@iceman201
iceman201 approved these changes Aug 29, 2021
View changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KaelWD KaelWD

@iceman201 iceman201

Assignees

@pikax pikax

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet