Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign uptest: fix ts api guardian and public guard tests on windows #30105
Conversation
This change addresses several issues with ts-api-guardian and public api guards related tests in Windows The fixes contain 3 main changes: 1) In `stripExportPattern` - replace `^` with `^^^^` in RegExp due to a double escaping requirment under Windows. Note that under Linux this the extra character has no effect because it's still a valid RegExp in Js. 2. Force `*.patch` files to always be with a LF line sequence instead of CRLF in windows 3. When adding JSDoc comments consider the presence of a carriage return in a line new feed Partially addresses #29785
alan-agius4
force-pushed the
alan-agius4:windows-fix-tests-guardian
branch
from
e544231
to
fde7ec3
|
|
alan-agius4
force-pushed the
alan-agius4:windows-fix-tests-guardian
branch
from
3c713d5
to
c922605
alan-agius4
force-pushed the
alan-agius4:windows-fix-tests-guardian
branch
from
c922605
to
2e2586f
…talled When the workspace node_modules are not installed outside of bazel context the api guardian tests fails because the tree artifacts files are not symlinked in windows. We need to pass the node module location in the node_path
alan-agius4
force-pushed the
alan-agius4:windows-fix-tests-guardian
branch
from
2e2586f
to
acf9d5e
AndrewKushnir
added
PR target: master-only
PR target: master & patch
and removed
PR target: master & patch
PR target: master-only
labels
AndrewKushnir
added a commit
that referenced
this pull request
Apr 26, 2019
This change addresses several issues with ts-api-guardian and public api guards related tests in Windows The fixes contain 3 main changes: 1) In `stripExportPattern` - replace `^` with `^^^^` in RegExp due to a double escaping requirment under Windows. Note that under Linux this the extra character has no effect because it's still a valid RegExp in Js. 2. Force `*.patch` files to always be with a LF line sequence instead of CRLF in windows 3. When adding JSDoc comments consider the presence of a carriage return in a line new feed Partially addresses #29785 PR Close #30105
AndrewKushnir
added a commit
that referenced
this pull request
Apr 26, 2019
AndrewKushnir
added a commit
that referenced
this pull request
Apr 26, 2019
BioPhoton
added a commit
to BioPhoton/angular
that referenced
this pull request
May 21, 2019
…30105) This change addresses several issues with ts-api-guardian and public api guards related tests in Windows The fixes contain 3 main changes: 1) In `stripExportPattern` - replace `^` with `^^^^` in RegExp due to a double escaping requirment under Windows. Note that under Linux this the extra character has no effect because it's still a valid RegExp in Js. 2. Force `*.patch` files to always be with a LF line sequence instead of CRLF in windows 3. When adding JSDoc comments consider the presence of a carriage return in a line new feed Partially addresses angular#29785 PR Close angular#30105
BioPhoton
added a commit
to BioPhoton/angular
that referenced
this pull request
May 21, 2019
PR Close angular#30105
BioPhoton
added a commit
to BioPhoton/angular
that referenced
this pull request
May 21, 2019
…talled (angular#30105) When the workspace node_modules are not installed outside of bazel context the api guardian tests fails because the tree artifacts files are not symlinked in windows. We need to pass the node module location in the node_path PR Close angular#30105
angular-automatic-lock-bot
bot
commented
Sep 15, 2019
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
alan-agius4 commentedApr 25, 2019
This change addresses several issues with ts-api-guardian and public api guards related tests in Windows
The fixes contain 3 main changes:
stripExportPattern- replace^with^^^^in RegExp due to a double escaping requirment under Windows. Note that under Linux this the extra character has no effect because it's still a valid RegExp in Js.Force
*.patchfiles to always be with a LF line sequence instead of CRLF in windowsWhen adding JSDoc comments consider the presence of a carriage return in a line new feed
Partially addresses #29785