Skip to content

docs: code style guide spaces #42908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

docs: code style guide spaces #42908

wants to merge 2 commits into from

Conversation

petebacondarwin
Copy link
Contributor

Fixes #42906

@petebacondarwin
docs: fix spacing in code style guide
ea8d03e 
Fixes angular#42906
@petebacondarwin
ci: fix typo in docs-bug issue template
5bb8721 
"browser specific" should be replaced with "browser-specific" because it's a compound modifier (cf. https://en.wikipedia.org/wiki/Compound_modifier).

See angular#42906
@petebacondarwin petebacondarwin added comp: docs action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Jul 21, 2021
@ngbot ngbot bot modified the milestone: Backlog Jul 21, 2021
@google-cla google-cla bot added the cla: yes label Jul 21, 2021
@pullapprove pullapprove bot requested a review from devversion July 21, 2021 13:08
@mary-poppins
Copy link

You can preview 5bb8721 at https://pr42908-5bb8721.ngbuilds.io/.

AndrewKushnir
AndrewKushnir approved these changes Jul 21, 2021
View reviewed changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

Note: this is a very low risk change and I think this PR is safe to land without extra approvals from the public-api group.

jessicajaniuk
jessicajaniuk approved these changes Jul 21, 2021
View reviewed changes
Copy link
Contributor

@jessicajaniuk jessicajaniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🍪

reviewed-for: public-api

@pullapprove pullapprove bot requested a review from zarend July 21, 2021 22:31
@petebacondarwin petebacondarwin added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jul 22, 2021
@petebacondarwin
Copy link
Contributor Author

Merge-assistance: see comment from @AndrewKushnir - #42908 (review)

@dylhunn dylhunn closed this in 5d222f3 Jul 22, 2021
dylhunn pushed a commit that referenced this pull request Jul 22, 2021
@petebacondarwin @dylhunn
ci: fix typo in docs-bug issue template (#42908)
7e9673d 
"browser specific" should be replaced with "browser-specific" because it's a compound modifier (cf. https://en.wikipedia.org/wiki/Compound_modifier).

See #42906

PR Close #42908
dylhunn pushed a commit that referenced this pull request Jul 22, 2021
@petebacondarwin @dylhunn
docs: fix spacing in code style guide (#42908)
dda23b9 
Fixes #42906

PR Close #42908
dylhunn pushed a commit that referenced this pull request Jul 22, 2021
@petebacondarwin @dylhunn
ci: fix typo in docs-bug issue template (#42908)
268ba5c 
"browser specific" should be replaced with "browser-specific" because it's a compound modifier (cf. https://en.wikipedia.org/wiki/Compound_modifier).

See #42906

PR Close #42908
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

@jessicajaniuk jessicajaniuk jessicajaniuk approved these changes

@alxhub alxhub Awaiting requested review from alxhub

@atscott atscott Awaiting requested review from atscott

@IgorMinar IgorMinar Awaiting requested review from IgorMinar

@zarend zarend Awaiting requested review from zarend

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

At/in https://angular.io/guide/styleguide, replace "principle(SRP)" with "principle (SRP)"
5 participants
@petebacondarwin @mary-poppins @devversion @AndrewKushnir @jessicajaniuk