Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set the RowHeight to prevent listview from being greedy #12346

Open
wants to merge 1 commit into
base: 5.0.0
from

Conversation

@t-johnson
Copy link

@t-johnson t-johnson commented Oct 3, 2020

Description of Change

Set the RowHeight to prevent the ListView from being greedy about space. This was causing the buttons in the StackLayout to shrink when the window was wide,

Issues Resolved

API Changes

None

Platforms Affected

  • Core/XAML (all platforms)

Behavioral/Visual Changes

None

Before/After Screenshots

Testing Procedure

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)
@samhouts samhouts added this to In Review in vNext+1 (5.0.0) Nov 2, 2020
@PureWeen PureWeen added this to In progress in v5.0.1 via automation Nov 5, 2020
@PureWeen PureWeen removed this from In Review in vNext+1 (5.0.0) Nov 5, 2020
@samhouts samhouts added this to In Review in vNext+1 (5.0.0) Nov 5, 2020
@samhouts samhouts removed this from In progress in v5.0.1 Nov 5, 2020
@PureWeen PureWeen added this to In progress in v5.0.1 via automation Nov 5, 2020
@PureWeen PureWeen removed this from In Review in vNext+1 (5.0.0) Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
v5.0.1
In progress
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.