Skip to content

/ kubernetes

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sig-cli] Find out more global flags be shadowed in kubectl #103835

Open
jyz0309 opened this issue Jul 22, 2021 · 12 comments · May be fixed by #103891
Open

[sig-cli] Find out more global flags be shadowed in kubectl #103835

jyz0309 opened this issue Jul 22, 2021 · 12 comments · May be fixed by #103891
Assignees
@mccricardo @GauravKakoti
Labels
good first issue help wanted kind/feature needs-triage sig/cli

Comments

@jyz0309
Copy link
Contributor

@jyz0309 jyz0309 commented Jul 22, 2021 •
edited

What would you like to be added:

As the #103769 comment said, --user flag has been shadowed by the root command flag and not show in the kubectl create clusterrolebinding --help command. We want to find out more flag which be shadowed and rename it.
Just like: #103809

Why is this needed:

For example, kubectl create rolebinding --help now not show the --user flag. But it's an optional flag for command. I think we need to show all flags that use in this command.
@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Jul 22, 2021

@jyz0309: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@jyz0309
Copy link
Contributor Author

@jyz0309 jyz0309 commented Jul 22, 2021 •
edited

/sig cli
@jyz0309
Copy link
Contributor Author

@jyz0309 jyz0309 commented Jul 22, 2021

/good-first-issue
@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Jul 22, 2021

@jyz0309:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@jyz0309 jyz0309 changed the title [sig-cli]Find out more global flags have been shadowed in kubectl [sig-cli] Find out more global flags have been shadowed in kubectl Jul 22, 2021
@jyz0309 jyz0309 changed the title [sig-cli] Find out more global flags have been shadowed in kubectl [sig-cli] Find out more global flags be shadowed in kubectl Jul 22, 2021
@kerthcet
Copy link
Member

@kerthcet kerthcet commented Jul 23, 2021

/assign glad to provide a help.
@kerthcet
Copy link
Member

@kerthcet kerthcet commented Jul 23, 2021

/assign
@mccricardo mccricardo linked a pull request that will close this issue Jul 24, 2021
Open
@mccricardo
Copy link

@mccricardo mccricardo commented Jul 24, 2021

@kerthcet I was messing around the codebase and found an instance in kubectl set subject and submitted a PR.
@kerthcet
Copy link
Member

@kerthcet kerthcet commented Jul 24, 2021

@kerthcet I was messing around the codebase and found an instance in kubectl set subject and submitted a PR.

sounds good. Or maybe you can help to find out more shadowed ones. it depends whatever.
@kerthcet
Copy link
Member

@kerthcet kerthcet commented Jul 24, 2021

/unassign
@mccricardo
Copy link

@mccricardo mccricardo commented Jul 25, 2021

@kerthcet I took a look and didn't find other instances. Assigning it to me then.
@mccricardo
Copy link

@mccricardo mccricardo commented Jul 25, 2021

/assign
@GauravKakoti
Copy link

@GauravKakoti GauravKakoti commented Jul 26, 2021

/assign
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mccricardo mccricardo

@GauravKakoti GauravKakoti

Labels
good first issue help wanted kind/feature needs-triage sig/cli
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Rename users flag for kubectl set subject --help
5 participants
@mccricardo @kerthcet @k8s-ci-robot @jyz0309 @GauravKakoti