New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-44353: Add tests to cover typing.NewType pickling #27302

Merged

ambv merged 3 commits into python:main from uriyyo:fix-issue-44353-tests

Jul 24, 2021

Member

uriyyo commented Jul 23, 2021 •

edited by bedevere-bot

https://bugs.python.org/issue44353

uriyyo requested a review from gvanrossum as a code owner

bedevere-bot added the awaiting review label

the-knights-who-say-ni added the CLA signed label

bedevere-bot added the type-tests label

Member Author

uriyyo commented Jul 23, 2021

@ambv Could you please review this PR and add skip-news label?

ambv added the skip news label

ambv reviewed

View changes

Lib/test/test_typing.py Show resolved Hide resolved

serhiy-storchaka reviewed

View changes

Lib/test/test_typing.py Outdated Show resolved Hide resolved

Lib/test/test_typing.py Outdated Show resolved Hide resolved

uriyyo requested review from Fidget-Spinner and serhiy-storchaka

Member Author

uriyyo commented Jul 23, 2021

@serhiy-storchaka What should I do with this PR?

Member

serhiy-storchaka commented Jul 23, 2021

See also #27311.

Member Author

uriyyo commented Jul 23, 2021

As far as I see #27311 will include code from this PR.

Should I close this issue?

Member

serhiy-storchaka commented Jul 23, 2021

__reduce__ should use __qualname__, not __name__.

You can either copy pickle-related code from #27311 or close this issue.

Member

serhiy-storchaka commented Jul 23, 2021

You need to copy also changes in constructor and tests.

Member Author

uriyyo commented Jul 23, 2021

Done, changes from your PR has been copied to this

uriyyo added 3 commits


          Add __reduce__ to NewType. Update pickle test

e17dddd


          Use __qualname__ instead of __name__

1f33fdf


          Update typing and test_typing

5c6cd2b

ambv force-pushed the fix-issue-44353-tests branch from 3563d76 to 5c6cd2b

Contributor

ambv commented Jul 24, 2021

Rebased over main after GH-27311 got merged.

ambv merged commit a22b05d into python:main

12 checks passed

bedevere-bot removed the awaiting review label

ambv added the needs backport to 3.10 label

Contributor

miss-islington commented Jul 24, 2021

Thanks @uriyyo for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

bedevere-bot commented Jul 24, 2021

GH-27328 is a backport of this pull request to the 3.10 branch.

bedevere-bot removed the needs backport to 3.10 label

miss-islington added a commit to miss-islington/cpython that referenced this issue


          bpo-44353: Improve tests covering typing.NewType pickling (pythonGH-2…

69130dd

…7302)

(cherry picked from commit a22b05d)

Co-authored-by: Yurii Karabas <1998uriyyo@gmail.com>

ambv pushed a commit that referenced this issue


          bpo-44353: Improve tests covering typing.NewType pickling (GH-27302) (G…

e8c0174

…H-27328)

(cherry picked from commit a22b05d)

Co-authored-by: Yurii Karabas <1998uriyyo@gmail.com>

Contributor

ambv commented Jul 24, 2021

Thanks a lot Yurii! ✨ 🍰 ✨

JuniorJPDJ added a commit to JuniorJPDJ/cpython that referenced this issue


          bpo-44353: Improve tests covering typing.NewType pickling (pythonGH-2…

b1ec241

…7302)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment