Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-38291: Fix a deprecation warning in typing tests #27312

Merged
merged 1 commit into from Jul 23, 2021
Merged

bpo-38291: Fix a deprecation warning in typing tests #27312

merged 1 commit into from Jul 23, 2021

Conversation

@srittau
Copy link
Contributor

@srittau srittau commented Jul 23, 2021 •
edited by bedevere-bot

The test was accessing typing.{io,re}.all, which triggered the
warning. This check isn't necessary anymore, since the objects from
typing.{io,re}.all are in typing.all as well, since Python 3.10.

A NEWS should not be required, since this affects the tests only.

Cc @serhiy-storchaka

https://bugs.python.org/issue38291
@srittau
Fix a deprecation warning in typing tests
095c33b 
The test was accessing typing.{io,re}.__all__, which triggered the
warning. This check isn't necessary anymore, since the objects from
typing.{io,re}.__all__ are in typing.__all__ as well, since Python 3.10.
@srittau srittau requested a review from gvanrossum as a code owner Jul 23, 2021
@srittau
Copy link
Contributor Author

@srittau srittau commented Jul 23, 2021

Aside: I could not reproduce the warning when running the tests locally.

@gvanrossum gvanrossum merged commit 4512848 into python:main Jul 23, 2021
12 checks passed
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jul 23, 2021

@gvanrossum: Please replace # with GH- in the commit message next time. Thanks!

@srittau srittau deleted the fix-typing-warnings branch Jul 23, 2021
JuniorJPDJ added a commit to JuniorJPDJ/cpython that referenced this issue Aug 12, 2021
@srittau @JuniorJPDJ
Fix a deprecation warning in typing tests (python#27312)
bc6e9f3 
The test was accessing typing.{io,re}.__all__, which triggered the
warning. This check isn't necessary anymore, since the objects from
typing.{io,re}.__all__ are in typing.__all__ as well, since Python 3.10.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra

@gvanrossum gvanrossum

Assignees
No one assigned
Labels
CLA signed skip news type-tests
Projects
None yet
Milestone
No milestone
5 participants
@srittau @bedevere-bot @JelleZijlstra @gvanrossum @the-knights-who-say-ni