python / cpython

Sponsor

Sponsor python/cpython
Notifications
Star 39.2k
Fork 19.5k

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-44676: Serialize the union type using only public API #27323

Merged

serhiy-storchaka merged 4 commits into python:main from serhiy-storchaka:union-pickle

Jul 24, 2021

+23 −80

Member

serhiy-storchaka commented Jul 24, 2021 •

edited by bedevere-bot

https://bugs.python.org/issue44676


          bpo-44676: Serialize the union type using only public API

d9a1d65

serhiy-storchaka added type-enhancement skip news labels

bedevere-bot added the awaiting core review label

the-knights-who-say-ni added the CLA signed label

Contributor

uriyyo commented Jul 24, 2021 •

edited

Should we also remove Union._from_args classmethod introduced by #27244? Basically, it was introduced for pickling support so looks like we don't need it anymore.

Fidget-Spinner reviewed

Contributor

Fidget-Spinner left a comment •

edited

Should we also remove Union._from_args classmethod introduced by #27244? Basically, it was introduced for pickling support so looks like we don't need it anymore.

Agreed. Lets remove it.

Note: we can only remove it if we're backporting this to 3.10. Pickle docs says its confirmed to be backwards compatible. So if we don't backport this, we have to leave the private method in forever :(. Either that, or we can remove serialization from 3.10, I created a PR at GH-27335 for that.

If Serhiy agrees to backporting this, we should probably consult the RM Pablo again.

  
      @@ -36,6 +36,12 @@ def pickle_complex(c):
    
            pickle(complex, pickle_complex, complex)

        def pickle_union(obj):

Fidget-Spinner Jul 24, 2021
Contributor

Off topic: I didn't know such a module existed 😮 . This is really cool! Thanks for teaching me something new today Serhiy.

uriyyo mentioned this pull request

bpo-44676: Add ability to serialise types.Union #27244

Merged

Contributor

Fidget-Spinner commented Jul 24, 2021 •

edited

Copied over from GH-27244, by Yurii:

@Fidget-Spinner I just realise that Union._from_args will be removed by #27323. I think we should backport #27323 to not introduce Union._from_args at python 3.10.

I agree with Yurii's reasoning here. +1 to backport this to 3.10 to remove _from_args from the API.

Alternatively, we can remove the ability to pickle Union in 3.10 (see GH-27333).

Fidget-Spinner mentioned this pull request

[3.10] Partially revert "bpo-44676: Add ability to serialize types.Union (GH-27244) (GH-27333)" #27335

Closed

Member Author

serhiy-storchaka commented Jul 24, 2021

Oh, I did not know this feature was backported to 3.10. It makes sense to haste and backport this PR too.

serhiy-storchaka added 2 commits


          Merge branch 'main' into union-pickle

3150a67


          Remove _from_args().

e812704

serhiy-storchaka requested a review from gvanrossum as a code owner


          Fix also _strip_annotations().

9f6f33f

serhiy-storchaka merged commit 435a033 into python:main

12 checks passed

12 checks passed

Check for source changes

Details

Check if generated files are up to date

Details

Windows (x86)

Details

Windows (x64)

Details

macOS

Details

Ubuntu

Details

Ubuntu SSL tests with OpenSSL

Details

Address sanitizer Address sanitizer

Details

Azure Pipelines PR #20210724.32 succeeded

Details

Travis CI - Pull Request Build Passed

Details

bedevere/issue-number Issue number 44676 found

Details

bedevere/news "skip news" label found

bedevere-bot removed the awaiting core review label

serhiy-storchaka deleted the serhiy-storchaka:union-pickle branch

serhiy-storchaka added the needs backport to 3.10 label

Contributor

miss-islington commented Jul 24, 2021

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

bedevere-bot commented Jul 24, 2021

GH-27340 is a backport of this pull request to the 3.10 branch.

bedevere-bot removed the needs backport to 3.10 label

miss-islington added a commit to miss-islington/cpython that referenced this pull request


          bpo-44676: Serialize the union type using only public API (pythonGH-2…

fe49cf5

…7323)

Remove also the _from_args() constructor.
(cherry picked from commit 435a033)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

serhiy-storchaka added a commit that referenced this pull request


          bpo-44676: Serialize the union type using only public API (GH-27323) (G…

0aea99e

…H-27340)

Remove also the _from_args() constructor.
(cherry picked from commit 435a033)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment