Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-44717: improve AttributeError on circular imports of submodules #27338

Merged
merged 7 commits into from Jul 24, 2021

Conversation

@FFY00
Copy link
Member

@FFY00 FFY00 commented Jul 24, 2021

#27299 was missing the new test data in the makefile. The build bot failed because the tests are installed to the system and run from there.

https://bugs.python.org/issue44717

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jul 24, 2021

🤖 New build scheduled with the buildbot fleet by @pablogsal for commit c890c3e 🤖

If you want to schedule another build, you need to add the "🔨 test-with-buildbots" label again.

Copy link
Member

@pablogsal pablogsal left a comment

LGTM

Thanks @FFY00 for the investigation and the quick fix!

@pablogsal pablogsal merged commit 0a8ae8a into python:main Jul 24, 2021
66 of 73 checks passed
66 of 73 checks passed
@github-actions
Docs
Details
@github-actions
Check for source changes
Details
@github-actions
Check if generated files are up to date
Details
@github-actions
Windows (x86)
Details
@github-actions
Windows (x64)
Details
@github-actions
macOS
Details
@github-actions
Ubuntu
Details
@github-actions
Ubuntu SSL tests with OpenSSL
Details
@github-actions
Address sanitizer Address sanitizer
Details
@bedevere-bot
buildbot/AMD64 Fedora Stable Refleaks PR Build started.
Details
@bedevere-bot
buildbot/AMD64 RHEL8 Refleaks PR Build started.
Details
@bedevere-bot
buildbot/AMD64 Windows8.1 Refleaks PR Build started.
Details
@bedevere-bot
buildbot/PPC64LE Fedora Stable Refleaks PR Build started.
Details
@bedevere-bot
buildbot/PPC64LE RHEL8 Refleaks PR Build started.
Details
@bedevere-bot
buildbot/s390x Fedora PR Build started.
Details
@bedevere-bot
buildbot/s390x RHEL8 Refleaks PR Build started.
Details
Azure Pipelines PR #20210724.33 succeeded
Details
@travis-ci
Travis CI - Pull Request Build Passed
Details
@bedevere-bot
bedevere/issue-number Issue number 44717 found
Details
@bedevere-bot
bedevere/news News entry found in Misc/NEWS.d
@bedevere-bot
buildbot/AMD64 Debian PGO PR Build done.
Details
@bedevere-bot
buildbot/AMD64 Debian root PR Build done.
Details
@bedevere-bot
buildbot/AMD64 Fedora Stable Clang Installed PR Build done.
Details
@bedevere-bot
buildbot/AMD64 Fedora Stable Clang PR Build done.
Details
@bedevere-bot
buildbot/AMD64 Fedora Stable LTO + PGO PR Build done.
Details
@bedevere-bot
buildbot/AMD64 Fedora Stable LTO PR Build done.
Details
@bedevere-bot
buildbot/AMD64 Fedora Stable PR Build done.
Details
@bedevere-bot
buildbot/AMD64 FreeBSD Non-Debug PR Build done.
Details
@bedevere-bot
buildbot/AMD64 FreeBSD Shared PR Build done.
Details
@bedevere-bot
buildbot/AMD64 RHEL7 LTO + PGO PR Build done.
Details
@bedevere-bot
buildbot/AMD64 RHEL7 LTO PR Build done.
Details
@bedevere-bot
buildbot/AMD64 RHEL7 PR Build done.
Details
@bedevere-bot
buildbot/AMD64 RHEL7 Refleaks PR Build done.
Details
@bedevere-bot
buildbot/AMD64 RHEL8 FIPS Only Blake2 Builtin Hash PR Build done.
Details
@bedevere-bot
buildbot/AMD64 RHEL8 LTO + PGO PR Build done.
Details
@bedevere-bot
buildbot/AMD64 RHEL8 LTO PR Build done.
Details
@bedevere-bot
buildbot/AMD64 RHEL8 PR Build done.
Details
@bedevere-bot
buildbot/AMD64 Ubuntu Shared PR Build done.
Details
@bedevere-bot
buildbot/AMD64 Windows10 PR Build done.
Details
@bedevere-bot
buildbot/AMD64 Windows10 Pro PR Build done.
Details
@bedevere-bot
buildbot/AMD64 Windows8.1 Non-Debug PR Build done.
Details
@bedevere-bot
buildbot/PPC64 Fedora PR Build done.
Details
@bedevere-bot
buildbot/PPC64LE Fedora Stable Clang Installed PR Build done.
Details
@bedevere-bot
buildbot/PPC64LE Fedora Stable Clang PR Build done.
Details
@bedevere-bot
buildbot/PPC64LE Fedora Stable LTO + PGO PR Build done.
Details
@bedevere-bot
buildbot/PPC64LE Fedora Stable LTO PR Build done.
Details
@bedevere-bot
buildbot/PPC64LE Fedora Stable PR Build done.
Details
@bedevere-bot
buildbot/PPC64LE RHEL7 LTO + PGO PR Build done.
Details
@bedevere-bot
buildbot/PPC64LE RHEL7 LTO PR Build done.
Details
@bedevere-bot
buildbot/PPC64LE RHEL7 PR Build done.
Details
@bedevere-bot
buildbot/PPC64LE RHEL7 Refleaks PR Build done.
Details
@bedevere-bot
buildbot/PPC64LE RHEL8 LTO + PGO PR Build done.
Details
@bedevere-bot
buildbot/PPC64LE RHEL8 LTO PR Build done.
Details
@bedevere-bot
buildbot/PPC64LE RHEL8 PR Build done.
Details
@bedevere-bot
buildbot/aarch64 Fedora Stable PR Build done.
Details
@bedevere-bot
buildbot/aarch64 RHEL8 PR Build done.
Details
@bedevere-bot
buildbot/s390x Debian PR Build done.
Details
@bedevere-bot
buildbot/s390x Fedora Clang Installed PR Build done.
Details
@bedevere-bot
buildbot/s390x Fedora Clang PR Build done.
Details
@bedevere-bot
buildbot/s390x Fedora LTO + PGO PR Build done.
Details
@bedevere-bot
buildbot/s390x Fedora LTO PR Build done.
Details
@bedevere-bot
buildbot/s390x Fedora Refleaks PR Build done.
Details
@bedevere-bot
buildbot/s390x RHEL7 LTO + PGO PR Build done.
Details
@bedevere-bot
buildbot/s390x RHEL7 LTO PR Build done.
Details
@bedevere-bot
buildbot/s390x RHEL7 PR Build done.
Details
@bedevere-bot
buildbot/s390x RHEL7 Refleaks PR Build done.
Details
@bedevere-bot
buildbot/s390x RHEL8 LTO + PGO PR Build done.
Details
@bedevere-bot
buildbot/s390x RHEL8 LTO PR Build done.
Details
@bedevere-bot
buildbot/s390x RHEL8 PR Build done.
Details
@bedevere-bot
buildbot/s390x SLES PR Build done.
Details
@bedevere-bot
buildbot/x86 Gentoo Installed with X PR Build done.
Details
@bedevere-bot
buildbot/x86 Gentoo Non-Debug with X PR Build done.
Details
@bedevere-bot
buildbot/x86-64 macOS PR Build done.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants