Fix generator publicPath behavior when empty string #13858
Merged
+25
−1
Conversation
|
For maintainers only:
|
|
@Janpot The most important CI builds failed. This way your PR can't be merged. Please take a look at the CI results from azure (0 errors / 0 warnings) and appveyor (failure) and fix these issues. |
sokra
merged commit beb42c6
into
webpack:main
37 of 38 checks passed
37 of 38 checks passed
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Fixing the second issue described in this PR vercel/next.js#27413 (comment)
empty string in
rule.generator.publicPathgets ignored.What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
yep
Does this PR introduce a breaking change?
nope
What needs to be documented once your changes are merged?
nothing