Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
"Cancel" first in menu #874
Comments
I'm currently leaning towards leaving it as-is given that the fact you already have to press two keys is sufficient friction in my mind (i.e. d + enter), but I'm interested in other people's thoughts |
If changing the order of the menu items is not desirable, then can we add an "are you sure" box? I don't know any UI in any system that would not present an "are you sure" box in response to a user action that discards all of their changes :) |
Good point, I think that makes sense |
Great, thank you |
…tions. add to recording. add recording.
…tions. add to recording. add recording. remove dialog
…tions. add to recording. add recording. remove dialog remove submodule prompt
…tions. add to recording. add recording. remove dialog remove submodule prompt
Hello,
In the two menus containing "destructive" actions (
d
andD
) can we have the "cancel" item first in the list? That way one doesn't accidentally hit enter and nuke their tree. Especially important since when you select one of those destructive actions there is not an "are you sure?" box that pops up. I think that the best solution which will keep the UI streamlined but make it a tad safer would just be to have the "cancel" item first in the list. That way, in order to nuke your tree, you have to press shift-d, down arrow, then enter, i.e., a key sequence that will only ever be typed intentionally. What say you?