Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Cancel" first in menu #874

Open
dpacbach opened this issue Jun 13, 2020 · 4 comments · May be fixed by #1083
Open

"Cancel" first in menu #874

dpacbach opened this issue Jun 13, 2020 · 4 comments · May be fixed by #1083

Comments

@dpacbach
Copy link

@dpacbach dpacbach commented Jun 13, 2020

Hello,

In the two menus containing "destructive" actions (d and D) can we have the "cancel" item first in the list? That way one doesn't accidentally hit enter and nuke their tree. Especially important since when you select one of those destructive actions there is not an "are you sure?" box that pops up. I think that the best solution which will keep the UI streamlined but make it a tad safer would just be to have the "cancel" item first in the list. That way, in order to nuke your tree, you have to press shift-d, down arrow, then enter, i.e., a key sequence that will only ever be typed intentionally. What say you?

@jesseduffield
Copy link
Owner

@jesseduffield jesseduffield commented Jul 18, 2020

I'm currently leaning towards leaving it as-is given that the fact you already have to press two keys is sufficient friction in my mind (i.e. d + enter), but I'm interested in other people's thoughts

@dpacbach
Copy link
Author

@dpacbach dpacbach commented Jul 19, 2020

If changing the order of the menu items is not desirable, then can we add an "are you sure" box? I don't know any UI in any system that would not present an "are you sure" box in response to a user action that discards all of their changes :)

@jesseduffield
Copy link
Owner

@jesseduffield jesseduffield commented Jul 19, 2020

Good point, I think that makes sense

@dpacbach
Copy link
Author

@dpacbach dpacbach commented Jul 22, 2020

Great, thank you

sstiglitz added a commit to sstiglitz/lazygit that referenced this issue Nov 16, 2020
sstiglitz added a commit to sstiglitz/lazygit that referenced this issue Nov 16, 2020
…tions.

add to recording.

add recording.
sstiglitz added a commit to sstiglitz/lazygit that referenced this issue Nov 16, 2020
…tions.

add to recording.

add recording.

remove dialog
sstiglitz added a commit to sstiglitz/lazygit that referenced this issue Nov 16, 2020
…tions.

add to recording.

add recording.

remove dialog

remove submodule prompt
sstiglitz added a commit to sstiglitz/lazygit that referenced this issue Nov 16, 2020
…tions.

add to recording.

add recording.

remove dialog

remove submodule prompt
sstiglitz added a commit to sstiglitz/lazygit that referenced this issue Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.