feat: Add n_bonacci.cpp in math section
#1544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Panquesito7
requested changes
Jul 21, 2021
There was a problem hiding this comment.
Good work! 👍
Please enable GitHub Actions in your repository of this fork in this link: https://github.com/Swastyy/C-Plus-Plus/actions
math/n_bonacci.cpp
Outdated
| * @param m is the number of terms in the N-Bonacci sequence | ||
| * @returns the n-bonacci sequence as vector array | ||
| */ | ||
| std::vector<int> N_bonacci(int n, unsigned int m) { |
There was a problem hiding this comment.
Consider using uint64_t for non-negative values (or their appropriate size: uint32_t, uint16_t, uint8_t) or int64_t for negative values. Check other parts of the code (reference). 🙂
math/n_bonacci.cpp
Outdated
| int main() { | ||
| test(); // run self-test implementations | ||
| return 0; | ||
| } |
Panquesito7
added
requested changes
Co-authored-by: David Leal <halfpacho@gmail.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
Panquesito7
requested changes
Jul 22, 2021
Co-authored-by: David Leal <halfpacho@gmail.com>
Panquesito7
approved these changes
Jul 25, 2021
Panquesito7
added
approved
|
@mishraabhinn See this PR has only my file. Check this out. |
Panquesito7
reviewed
Jul 29, 2021
mishraabhinn
approved these changes
Jul 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change Created n _ bonacci series upto given m number of terms.
Checklist
Notes: Fixes for https://github.com/TheAlgorithms/C-Plus-Plus/projects/6#card-63413779