Skip to content

bpo-41255: handle argparse errors with exit_on_error=False consistently #27295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

bpo-41255: handle argparse errors with exit_on_error=False consistently #27295

wants to merge 4 commits into from

Conversation

joshmeranda
Copy link

@joshmeranda joshmeranda commented Jul 22, 2021 •
edited by bedevere-bot
Loading

bpo-41255

When unknown arguments are passed to parse_args or required arguments not passed to either parse_args or parse_known_args argpase exits despite exit_on_error=False. This is not very intuitive, instead any error parsing arguments should result in an ArgumentError which can be handled by the user.

https://bugs.python.org/issue41255

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@joshmeranda

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Aug 27, 2021
@jacobtylerwalls jacobtylerwalls mentioned this pull request Feb 5, 2022
Closed
MaxwellDupre
MaxwellDupre approved these changes Mar 14, 2022
View reviewed changes
Copy link
Contributor

@MaxwellDupre MaxwellDupre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me:
Ran 1658 tests in 2.516s
OK

Simple bug mentioned case too!
Nice work

@matthewhughes934 matthewhughes934 mannequin mentioned this pull request Apr 10, 2022
Closed
@AA-Turner AA-Turner closed this Jun 7, 2022
@AA-Turner AA-Turner reopened this Jun 7, 2022
@AA-Turner
Copy link
Member

Trigger CLA.

A

@AA-Turner AA-Turner added type-bug An unexpected behavior, bug, or error stdlib Python modules in the Lib dir and removed CLA signed stale Stale PR or inactive for long period of time. labels Jun 7, 2022
@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Aug 11, 2022
@serhiy-storchaka
Copy link
Member

Thank you for your contribution @joshmeranda. I apologize for the fact that this PR was neglected for a long time. The problem has already been solved in another way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxwellDupre MaxwellDupre MaxwellDupre approved these changes

Assignees
No one assigned
Labels
awaiting core review stale Stale PR or inactive for long period of time. stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@joshmeranda @the-knights-who-say-ni @AA-Turner @serhiy-storchaka @MaxwellDupre @bedevere-bot