Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-44717: Revert "improve AttributeError on circular imports of submodules" #27331

Merged
merged 1 commit into from Jul 24, 2021
Merged

bpo-44717: Revert "improve AttributeError on circular imports of submodules" #27331

merged 1 commit into from Jul 24, 2021

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Jul 24, 2021 •
edited by bedevere-bot

@pablogsal pablogsal requested a review from FFY00 Jul 24, 2021
@pablogsal
Copy link
Member Author

pablogsal commented Jul 24, 2021

I'm reverting since this failures are already causing plenty of confusion unfortunately

@pablogsal pablogsal requested a review from ambv Jul 24, 2021
FFY00
FFY00 approved these changes Jul 24, 2021
View changes
Copy link
Member

@FFY00 FFY00 left a comment

Ack, I will try to have a look at why the build bots are failing soon.

@pablogsal pablogsal merged commit 3eae8f2 into main Jul 24, 2021
13 checks passed
@pablogsal pablogsal deleted the revert-27299-bpo-44717 branch Jul 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FFY00 FFY00

@ambv ambv

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pablogsal @FFY00 @the-knights-who-say-ni @bedevere-bot