solidity

🎉 Description

The ECDSA contract has a function toEthSignedMessage(bytes32), but we should have a function that works for any length of a bytes array:

function toEthSignedMessage(bytes s) pure internal returns (bytes32) {
  return keccak256(
    "\x19Ethereum Signed Message:\n",
    uintToBytes(s.length),
    s);
}

Where uintToBytes is implemented from an ideally

Looks like soldity-upgrade has input file processing logic duplicated from CommandLineInterface.cpp. Especially readInputFiles() and file reader callback in SourceUpgrade.cpp. This logic in CommandLineInterface has recently been refactored in PRs like #11113, #11518. After #11545/#11617

Hi, just wondering why there are no tests in the scaffolded project when running truffle init...

Can I make a PR adding this? Where in the main truffle source code should I put this file?

thanks!

Description
Add a contract similar to Aave's AddressProvider or Uniswap's getPair() functionality.

Motivation
On-chain lookups of price oracles given the asset addresses.

Justification
String manipulation is difficult and expensive in Solidity, and you usually work with the token address, not its string name.

This was reported by @nventuro

If you have your own artifacts-loading logic, and have a contract that needs to be linked, our plugin doesn't help you. You'd have to link the libraries manually.

We should have overloads that take an Artifact, and take care of the library linking.

getContractAt doesn't really need this overload, but it would be great to be consistent.

From @Arachnid recent tweet, it looks like there is not good up to date solution to generate doc from natspec. We should explore the current solutions and create something on top of slither

Overview

Currently when I run brownie console, it recompiles all the contracts. Apparently due to some issue which is not identified.

I only want to compile once with brownie compile -all. That's it.
I work on the frontend side, I don't modify the contracts, I just need a local fork and run some scripts.

Currently it's slow as hell

We can safely disallow any use of solc below 0.4.25.

I left a review and then got this message

which seems strange as it's telling me something I know.