Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace external actions in CI #244

Open
simonsan opened this issue Mar 1, 2021 · 5 comments
Open

Replace external actions in CI #244

simonsan opened this issue Mar 1, 2021 · 5 comments

Comments

@simonsan
Copy link
Collaborator

@simonsan simonsan commented Mar 1, 2021

As preparation for a possible inclusion into rust-lang we should replace the external actions we use with e.g. scripts that do the same.

rust-lang/std-dev-guide#7 (comment)

That PR also shows how that could be done:
https://github.com/rust-lang/std-dev-guide/pull/7/files

@MarcoIeni
Copy link
Collaborator

@MarcoIeni MarcoIeni commented Mar 2, 2021

I think I would do it only immediately before moving the book under rust-lang.
Implementing all the actions by ourselves means that we have to maintain them in the meantime. For now we can save that effort.

Furthermore, I am not sure that all the repositories under rust-lang are not using external actions. This is just an example.
We need to ask clarifications about this.

So for the moment I would close this issue.

@simonsan
Copy link
Collaborator Author

@simonsan simonsan commented Mar 2, 2021

I think it's actually important to not close this. Also in the PR I did I showed how to do it without external actions. We don't need to reimplement actions ourselves. A bit of copy & pasting from the PR and a bit of own work and this should be fine.

@MarcoIeni
Copy link
Collaborator

@MarcoIeni MarcoIeni commented Mar 3, 2021

Yeah, the problem with copy pasting is that you have to maintain it.
From a security point of view, what's the difference with fixing the version of the github action with the release version or the commit hash for example?

@simonsan
Copy link
Collaborator Author

@simonsan simonsan commented Mar 3, 2021

From a security point of view, what's the difference with fixing the version of the github action with the release version or the commit hash for example?

I don't understand that question, could you rephrase it please? I mean a Github action has access to environment variables, if this will make it into rust-lang they sure want to keep track of which actions have access to these and that there are no malicious one's under it. To check/code review each of those actions is also a bit much, no?

@MarcoIeni
Copy link
Collaborator

@MarcoIeni MarcoIeni commented Oct 17, 2021

I don't understand that question, could you rephrase it please?

Isn't copy pasting source code the same as using a specific commit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants