Update to latest async lightbulb api #55207
Open
+55
−18
Conversation
| { | ||
| // Always ensure that all the collectors are marked as complete so we don't hang the UI. | ||
| foreach (var collector in collectors) | ||
| collector.Complete(); |
CyrusNajmabadi
Jul 29, 2021
Author
Contributor
@AmadeusW i hope this is ok. First, i really don't want to have to keep track of what collectors i already called Complete on. Second, it feels weird that the callee needs to do this. the caller can just move all collectors to the completed state once the async call has completed.
| @@ -39,7 +39,6 @@ internal static class WellKnownExperimentNames | |||
| public const string OOPServerGC = "Roslyn.OOPServerGC"; | |||
| public const string LspTextSyncEnabled = "Roslyn.LspTextSyncEnabled"; | |||
| public const string ImportsOnPasteDefaultEnabled = "Roslyn.ImportsOnPasteDefaultEnabled"; | |||
| public const string LspTextSyncEnabled = "Roslyn.LspTextSyncEnabled"; | |||
CyrusNajmabadi
Jul 29, 2021
Author
Contributor
some bad earlier merge caused this. it's already defined two lines above, so this was causing a build break
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
No description provided.