bpo-44752: Make rlcompleter not call @property methods
#27401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* rlcompleter was calling these methods to identify whether to add parenthesis to the completion, based on if the attribute is callable. * for property objects, completion with parenthesis are never desirable. * property methods with print statements behaved very strangely, which was especially unfriendly to language newcomers. <tab> could suddenly produce output unexpectedly.
jdevries3133
commented
Jul 28, 2021
ambv
reviewed
Jul 28, 2021
|
@ambv, I see what you mean now about that change weakening the test. I created a new test case, and revised the original one to use the original assertions, now using |
ambv
changed the title
@property methods@property methods
|
Thanks @jdevries3133 for the PR, and @ambv for merging it |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 29, 2021
) * rlcompleter was calling these methods to identify whether to add parenthesis to the completion, based on if the attribute is callable. * for property objects, completion with parenthesis are never desirable. * property methods with print statements behaved very strangely, which was especially unfriendly to language newcomers. <tab> could suddenly produce output unexpectedly. (cherry picked from commit 50de8f7) Co-authored-by: Jack DeVries <58614260+jdevries3133@users.noreply.github.com>
|
GH-27444 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 29, 2021
) * rlcompleter was calling these methods to identify whether to add parenthesis to the completion, based on if the attribute is callable. * for property objects, completion with parenthesis are never desirable. * property methods with print statements behaved very strangely, which was especially unfriendly to language newcomers. <tab> could suddenly produce output unexpectedly. (cherry picked from commit 50de8f7) Co-authored-by: Jack DeVries <58614260+jdevries3133@users.noreply.github.com>
|
GH-27445 is a backport of this pull request to the 3.9 branch. |
ambv
pushed a commit
that referenced
this pull request
Jul 29, 2021
…H-27444) * rlcompleter was calling these methods to identify whether to add parenthesis to the completion, based on if the attribute is callable. * for property objects, completion with parenthesis are never desirable. * property methods with print statements behaved very strangely, which was especially unfriendly to language newcomers. <tab> could suddenly produce output unexpectedly. (cherry picked from commit 50de8f7) Co-authored-by: Jack DeVries <58614260+jdevries3133@users.noreply.github.com>
ambv
pushed a commit
that referenced
this pull request
Jul 29, 2021
…27445) * rlcompleter was calling these methods to identify whether to add parenthesis to the completion, based on if the attribute is callable. * for property objects, completion with parenthesis are never desirable. * property methods with print statements behaved very strangely, which was especially unfriendly to language newcomers. <tab> could suddenly produce output unexpectedly. (cherry picked from commit 50de8f7) Co-authored-by: Jack DeVries <58614260+jdevries3133@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
parenthesis to the completion, based on if the attribute is callable.
was especially unfriendly to language newcomers. could suddenly
produce output unexpectedly.
https://bugs.python.org/issue44752