Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-44752: refactor part of rlcompleter.Completer.attr_matches #27433

Merged
merged 2 commits into from Jul 29, 2021
Merged

bpo-44752: refactor part of rlcompleter.Completer.attr_matches #27433

merged 2 commits into from Jul 29, 2021

Conversation

jdevries3133
Copy link
Contributor

@jdevries3133 jdevries3133 commented Jul 28, 2021 •
edited by bedevere-bot

See the discussion about this change here:

#27401 (comment)

https://bugs.python.org/issue44752

@jdevries3133 jdevries3133 mentioned this pull request Jul 28, 2021
Merged
@ambv ambv added the skip news label Jul 29, 2021
@ambv
Copy link
Contributor

ambv commented Jul 29, 2021

This will require resolving the conflict with the currently landed GH-27401, @jdevries3133.

@jdevries3133
Copy link
Contributor Author

jdevries3133 commented Jul 29, 2021

@ambv merged!

@ambv
Copy link
Contributor

ambv commented Jul 29, 2021

The ASAN failure is a re-run timeout.

@ambv ambv merged commit 6741794 into python:main Jul 29, 2021
11 of 12 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Jul 29, 2021

Thanks @jdevries3133 for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Jul 29, 2021

Thanks @jdevries3133 for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-bot
Copy link

bedevere-bot commented Jul 29, 2021

GH-27446 is a backport of this pull request to the 3.9 branch.

@bedevere-bot
Copy link

bedevere-bot commented Jul 29, 2021

GH-27447 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 29, 2021
@jdevries3133 @miss-islington
bpo-44752: refactor part of rlcompleter.Completer.attr_matches (pytho…
1a6bea5 
…nGH-27433)

(cherry picked from commit 6741794)

Co-authored-by: Jack DeVries <58614260+jdevries3133@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 29, 2021
@jdevries3133 @miss-islington
bpo-44752: refactor part of rlcompleter.Completer.attr_matches (pytho…
54931ce 
…nGH-27433)

(cherry picked from commit 6741794)

Co-authored-by: Jack DeVries <58614260+jdevries3133@users.noreply.github.com>
ambv pushed a commit that referenced this pull request Jul 29, 2021
@miss-islington @jdevries3133
bpo-44752: refactor part of rlcompleter.Completer.attr_matches (GH-27433
f8e13e3 
) (GH-27447)

(cherry picked from commit 6741794)

Co-authored-by: Jack DeVries <58614260+jdevries3133@users.noreply.github.com>
ambv pushed a commit that referenced this pull request Jul 29, 2021
@miss-islington @jdevries3133
bpo-44752: refactor part of rlcompleter.Completer.attr_matches (GH-27433
93d9087 
) (GH-27446)

(cherry picked from commit 6741794)

Co-authored-by: Jack DeVries <58614260+jdevries3133@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jdevries3133 @ambv @miss-islington @bedevere-bot @the-knights-who-say-ni