[3.9] bpo-44752: Make rlcompleter not call @property methods (GH-27401)
#27445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) * rlcompleter was calling these methods to identify whether to add parenthesis to the completion, based on if the attribute is callable. * for property objects, completion with parenthesis are never desirable. * property methods with print statements behaved very strangely, which was especially unfriendly to language newcomers. <tab> could suddenly produce output unexpectedly. (cherry picked from commit 50de8f7) Co-authored-by: Jack DeVries <58614260+jdevries3133@users.noreply.github.com>
|
@jdevries3133 and @ambv: Status check is done, and it's a success ✅ . |
1 similar comment
|
@jdevries3133 and @ambv: Status check is done, and it's a success ✅ . |
|
@ambv: Please replace |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parenthesis to the completion, based on if the attribute is callable.
was especially unfriendly to language newcomers. could suddenly
produce output unexpectedly.
(cherry picked from commit 50de8f7)
Co-authored-by: Jack DeVries 58614260+jdevries3133@users.noreply.github.com
https://bugs.python.org/issue44752