Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

• Always add tests
• Keep backward compatibility (see https://symfony.com/bc).
• Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
• Features and deprecations must be submitted against the 5.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

Rebased and fixed the issue found by psalm.

Hey!

I think @atailouloute has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

There are several aspects to consider here:

• changing the default behavior. This is a risky move: users on shared hosts might be impacted. Maybe this is niche, but the Symfony community is large enough for someone to be impacted. Better not IMHO.
• adding arguments to existing methods is a BC break so we'd need a BC layer to add those args. We can provide guidance on this.
• but before that: do we want to make this the responsibility of the method? What about keeping everything as is and letting you (the caller) add a few more chmod before/after? That'd be the safer, history wise to me.

Let me close since this is quite old. Feel free to challenge of course.