Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebProfilerBundle] [WebProfiler] "empty" filter bugfix. Filter with name "empty" is not … #42270

Merged
merged 1 commit into from Jul 27, 2021

Conversation

luzrain
Copy link
Contributor

@luzrain luzrain commented Jul 26, 2021

There is a bug, which make web profiler is completely broken with Mailer extension installed.
Bug is presented always in branches 5.2 and 5.3.

@carsonbot carsonbot added this to the 4.4 milestone Jul 26, 2021
@carsonbot
Copy link

carsonbot commented Jul 26, 2021

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 5.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@OskarStark
Copy link
Contributor

OskarStark commented Jul 26, 2021

Is this a duplicate of #42269?

cc @sidz

@carsonbot carsonbot changed the title [WebProfiler] "empty" filter bugfix. Filter with name "empty" is not … [WebProfilerBundle] [WebProfiler] "empty" filter bugfix. Filter with name "empty" is not … Jul 26, 2021
@OskarStark OskarStark added the Bug label Jul 26, 2021
@sidz
Copy link
Contributor

sidz commented Jul 26, 2021

@OskarStark yup.

fabpot
fabpot approved these changes Jul 27, 2021
@fabpot
Copy link
Member

fabpot commented Jul 27, 2021

Thank you @luzrain.

@fabpot fabpot merged commit 6f2df38 into symfony:4.4 Jul 27, 2021
9 of 10 checks passed
This was referenced Jul 27, 2021
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants