Skip to content

/ symfony

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dotenv][Yaml] Remove PHP 8.0 polyfill #42296

Merged
merged 1 commit into from Jul 29, 2021
Merged

[Dotenv][Yaml] Remove PHP 8.0 polyfill #42296

merged 1 commit into from Jul 29, 2021
+30 −32

Conversation

@derrabus
Copy link
Member

@derrabus derrabus commented Jul 27, 2021

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #42280
License MIT
Doc PR N/A

This is a partial revert of #41576 and #41973.
@derrabus
Remove polyfills from Yaml and Dotenv
08ecbf5 
Signed-off-by: Alexander M. Turek <me@derrabus.de>
@derrabus derrabus requested a review from xabbuh as a code owner Jul 27, 2021
@carsonbot carsonbot added this to the 4.4 milestone Jul 27, 2021
@carsonbot carsonbot changed the title [DotEnv][Yaml] Remove PHP 8.0 polyfill [Dotenv][Yaml] Remove PHP 8.0 polyfill Jul 27, 2021
@derrabus derrabus mentioned this pull request Jul 27, 2021
Closed
@derrabus derrabus linked an issue that may be closed by this pull request Jul 27, 2021
Symfony 4.4.27 upgrade falls over on PHP 7.4 when calling str_contains #42280
Closed
@simonschaufi
simonschaufi approved these changes Jul 27, 2021
View changes
@crmpicco
Copy link

@crmpicco crmpicco commented Jul 28, 2021

Great work. Keen to see this merged in and released.
@YohannsMonnier
Copy link

@YohannsMonnier YohannsMonnier commented Jul 28, 2021 •
edited

Dear @derrabus , this fix should also apply to 5.3.5 too.
@derrabus
Copy link
Member Author

@derrabus derrabus commented Jul 28, 2021

No worries, we're merging everything up.
@fabpot
fabpot approved these changes Jul 29, 2021
View changes
@fabpot
Copy link
Member

@fabpot fabpot commented Jul 29, 2021

Thank you @derrabus.
@fabpot fabpot merged commit 192e360 into symfony:4.4 Jul 29, 2021
10 checks passed
10 checks passed
@github-actions
Tests (7.1)
Details
@github-actions
Tests (7.2)
Details
@github-actions
Psalm
Details
@github-actions
Tests (8.0)
Details
@github-actions
Tests (8.0)
Details
@github-actions
Tests (7.4, high-deps)
Details
@github-actions
Tests (8.0, low-deps)
Details
@github-actions
Tests (8.1, experimental) Tests (8.1, experimental)
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
fabbot.io Your code looks good.
Details
This was referenced Jul 29, 2021
Merged
Merged
Merged
@derrabus derrabus deleted the derrabus:bugfix/remove-polyfills branch Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot

@simonschaufi simonschaufi

@xabbuh xabbuh

Assignees
No one assigned
Labels
Bug Dotenv Status: Reviewed Yaml
Projects
None yet
Milestone
4.4
Linked issues

Successfully merging this pull request may close these issues.

Symfony 4.4.27 upgrade falls over on PHP 7.4 when calling str_contains
6 participants
@derrabus @crmpicco @YohannsMonnier @fabpot @simonschaufi @carsonbot