[HttpKernel] always close open stopwatch section after handling kernel.request
events
#42331
+19
−16
Conversation
Member
xabbuh
commented
Jul 30, 2021
|
kernel.request
events
Thank you @xabbuh. |
f2f96a0
into
symfony:4.4
10 of 11 checks passed
10 of 11 checks passed
herndlm
added a commit
to herndlm/symfony
that referenced
this pull request
Sep 1, 2021
In order for the TimeDataCollector to work properly the X-Debug-Token from the response header needs to be used which was removed in symfony#42331 to fix symfony#36623. Fixes symfony#42804
herndlm
added a commit
to herndlm/symfony
that referenced
this pull request
Sep 1, 2021
In order for the `TimeDataCollector` to work properly the `X-Debug-Token` from the response header needs to be used which was removed in symfony#42331 to fix symfony#36623. Fixes symfony#42804
fabpot
added a commit
that referenced
this pull request
Sep 1, 2021
This PR was merged into the 4.4 branch. Discussion ---------- [HttpKernel] Fix empty timeline in profiler Simple fix to #42804 | Q | A | ------------- | --- | Branch? | 5.3 && 4.4 | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | Fix #42804 <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT Fix #42804 following #42331 conventions Another solution could be found here #42823 <!-- Replace this notice by a short README for your feature/bugfix. This will help people understand your PR and can be used as a start for the documentation. Additionally (see https://symfony.com/releases): - Always add tests and ensure they pass. - Never break backward compatibility (see https://symfony.com/bc). - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too.) - Features and deprecations must be submitted against branch 5.x. - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry --> Commits ------- f1b3840 [HttpKernel] Fix timeline in profiler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.