Skip to content
#

apis

Here are 774 public repositories matching this topic...

public-apis
kuma
jpeach
jpeach commented Jul 9, 2021

Summary

Most Kuma annotations use GetEnabled but kuma.io/sidecar-injected uses GetBool. This means that, even though kuma.io/sidecar-injected is a boolean annotation like plenty of others in Kuma, it doesn't not accept the same set of values.

We should dump GetBool and add strconv.ParseBool support to GetEnabled so that we have just one consistent way of handling boolean an

bethesque
bethesque commented Jul 22, 2021

Please add support for the following keys to be used in the consumer version selectors when fetching pacts for verification:

{ "deployedOrReleased": true }

{ "deployed": true }

{ "released": true }

{ "environment": "<env name>" }

These keys can be used in various combinations ( eg. { "environment": "prod", released: true, consumer: "Foo" } ). Please allow any combination

bethesque
bethesque commented Jul 22, 2021

Please add support for the following keys to be used in the consumer version selectors when fetching pacts for verification:

{ "deployedOrReleased": true }

{ "deployed": true }

{ "released": true }

{ "environment": "<env name>" }

{ "consumer": "<name>" } // this may already be supported, please add it if not

These keys can be used in various combinations ( eg. `{ "envir

Improve this page

Add a description, image, and links to the apis topic page so that developers can more easily learn about it.

Curate this topic

Add this topic to your repo

To associate your repository with the apis topic, visit your repo's landing page and select "manage topics."

Learn more