Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update URLs in comments and metadata to use HTTPS #27458

Merged
merged 3 commits into from Jul 30, 2021
Merged

Update URLs in comments and metadata to use HTTPS #27458

merged 3 commits into from Jul 30, 2021

Conversation

@coderanger
Copy link
Member

@coderanger coderanger commented Jul 29, 2021 •
edited by terryjreedy

Update four to current locations.
Initially reported by Raphael raphaelvowles@yahoo.co.uk via webmaster@python for the metadata.
@coderanger
Update many URLs in comments and metadata to use HTTPS and update a f…
ce21a9b 
…ew to newer locations to fight linkrot.
@coderanger coderanger requested review from 1st1, lysnikolaou, pablogsal, rhettinger, terryjreedy and python/macos-team as code owners Jul 29, 2021
@the-knights-who-say-ni
Copy link

@the-knights-who-say-ni the-knights-who-say-ni commented Jul 29, 2021

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@coderanger

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!
@terryjreedy terryjreedy changed the title Update many URLs in comments and metadata to use HTTPS and update a few to newer locations to fight linkrot Update URLs in comments and metadata to use HTTPS and update a few to newer locations to fight linkrot Jul 29, 2021
@terryjreedy terryjreedy changed the title Update URLs in comments and metadata to use HTTPS and update a few to newer locations to fight linkrot Update URLs in comments and metadata to use HTTPS Jul 29, 2021
@coderanger
Update a test.
57d91c9
@terryjreedy
terryjreedy approved these changes Jul 29, 2021
View changes
Copy link
Member

@terryjreedy terryjreedy left a comment

I would not normally review until CLA signed, but this is equivalent to typo fixes.
Please note when you sign. It usually takes a working day or two to get recorded.

Did you change all URLs or skip some after testing?
Doc/conf.py
@@ -85,7 +85,7 @@

# Custom sidebar templates, filenames relative to this file.
html_sidebars = {
# Defaults taken from http://www.sphinx-doc.org/en/stable/config.html#confval-html_sidebars
# Defaults taken from https://www.sphinx-doc.org/en/master/usage/configuration.html#confval-html_sidebars

This comment has been minimized.

Sign in to view
@terryjreedy

terryjreedy Jul 29, 2021
Member

The old url is forwarded to this.
Mac/README.rst Outdated
@@ -399,8 +399,8 @@ The basic implementation pattern is:
Resources
=========

* http://www.python.org/download/mac/
* https://www.python.org/downloads/mac-osx/

This comment has been minimized.

Sign in to view
@terryjreedy

terryjreedy Jul 29, 2021
Member

Old URL forwards to this.

This comment has been minimized.

Sign in to view
@ambv

ambv Jul 29, 2021
Contributor

Please don't change this occurence as "mac-osx" is an outdated term. We should rather fix the website to use the modern "macOS" term instead.

This comment has been minimized.

Sign in to view
@coderanger

coderanger Jul 29, 2021
Author Member

I think that's best left to a later discussion, this reflects the current state of the world :)

This comment has been minimized.

Sign in to view
@ambv

ambv Jul 29, 2021
Contributor

The current state of the world is that the redirect works and we don't need to modify the line in the README. If we do, we'll have to change the README again.

This comment has been minimized.

Sign in to view
@ambv

ambv Jul 29, 2021
Contributor

(if you only want to s/http/https/ then that's obviously fine)

This comment has been minimized.

Sign in to view
@coderanger

coderanger Jul 29, 2021 •
edited
Author Member

Yes? Changing it again will be correct, unless you want me to just go change the website now, which I can also do :) Relying on redirects leads to rot and should be avoided.

This comment has been minimized.

Sign in to view
@coderanger

coderanger Jul 29, 2021
Author Member

https://github.com/python/pythondotorg/blob/7556542b58d9c90717757c9fa997637752d6dd85/pydotorg/urls.py#L30 is what's performing the current redirect, but changing this will have deeper impact on a number of views. I understand your point that mac-osx is an out of date reference but it's the correct one for python.org.

This comment has been minimized.

Sign in to view
@ambv

ambv Jul 29, 2021
Contributor

I changed the DB entry on python.org. The URL is now:
https://www.python.org/downloads/macos/

Unfortunately, as you noted, some things are needlessly static in the source code. I created this PR to update it:
python/pythondotorg#1829
setup.py
@@ -1237,7 +1237,7 @@ def detect_dbm_gdbm(self):
# similar functionality (but slower of course) implemented in Python.

# Sleepycat^WOracle Berkeley DB interface.
# http://www.oracle.com/database/berkeley-db/db/index.html
# https://www.oracle.com/database/technologies/related/berkeleydb.html

This comment has been minimized.

Sign in to view
@terryjreedy

terryjreedy Jul 29, 2021
Member

Old URL forwards to this.
setup.py
@@ -1279,7 +1279,7 @@ def gen_db_minor_ver_nums(major):
'/usr/include/db3',
'/usr/local/include/db3',
'/opt/sfw/include/db3',
# Fink defaults (http://fink.sourceforge.net/)
# Fink defaults (https://www.finkproject.org/)

This comment has been minimized.

Sign in to view
@terryjreedy

terryjreedy Jul 29, 2021
Member

Old url flakey; if it works, gets forwarded to new page, which was updated yesterday.
@coderanger
Copy link
Member Author

@coderanger coderanger commented Jul 29, 2021

I was mostly targeting rg 'http://(www\.)?python\.org' -g '!Lib/test/**' but fixed a few others in the same files while I was there.
@coderanger
Update macOS link to match python/pythondotorg#1829
2f2a9e5
@ambv ambv merged commit be42c06 into main Jul 30, 2021
15 checks passed
15 checks passed
@github-actions
Docs
Details
@github-actions
Check for source changes
Details
@github-actions
Windows (x86) Installer
Details
@github-actions
Check if generated files are up to date
Details
@github-actions
Windows (x64) Installer
Details
@github-actions
Windows (x86)
Details
@github-actions
Windows (x64)
Details
@github-actions
macOS
Details
@github-actions
Ubuntu
Details
@github-actions
Ubuntu SSL tests with OpenSSL
Details
@github-actions
Address sanitizer Address sanitizer
Details
Azure Pipelines PR #20210729.58 succeeded
Details
@travis-ci
Travis CI - Pull Request Build Passed
Details
@bedevere-bot
bedevere/issue-number Issue report skipped
@bedevere-bot
bedevere/news "skip news" label found
@ambv ambv deleted the https-links branch Jul 30, 2021
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jul 30, 2021

Thanks @coderanger for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9.
🐍🍒⛏🤖
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jul 30, 2021

GH-27478 is a backport of this pull request to the 3.10 branch.
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jul 30, 2021

Sorry, @coderanger and @ambv, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker be42c06bb01206209430f3ac08b72643dc7cad1c 3.9
miss-islington added a commit to miss-islington/cpython that referenced this pull request Jul 30, 2021
@coderanger @miss-islington
Update URLs in comments and metadata to use HTTPS (pythonGH-27458)
1f15eea 
(cherry picked from commit be42c06)

Co-authored-by: Noah Kantrowitz <noah@coderanger.net>
ambv added a commit to ambv/cpython that referenced this pull request Jul 30, 2021
@coderanger @ambv
[3.9] Update URLs in comments and metadata to use HTTPS (pythonGH-27458…
5f5de15 
…).

(cherry picked from commit be42c06)

Co-authored-by: Noah Kantrowitz <noah@coderanger.net>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jul 30, 2021

GH-27480 is a backport of this pull request to the 3.9 branch.
ambv pushed a commit that referenced this pull request Jul 30, 2021
@miss-islington @coderanger
Update URLs in comments and metadata to use HTTPS (GH-27458) (GH-27478)
f7f1c26 
(cherry picked from commit be42c06)

Co-authored-by: Noah Kantrowitz <noah@coderanger.net>
ambv added a commit that referenced this pull request Jul 30, 2021
@ambv @coderanger
[3.9] Update URLs in comments and metadata to use HTTPS (GH-27458) (G…
168879e 
…H-27480)

(cherry picked from commit be42c06)

Co-authored-by: Noah Kantrowitz <noah@coderanger.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ambv ambv

@terryjreedy terryjreedy

@1st1 1st1

@lysnikolaou lysnikolaou

@pablogsal pablogsal

@rhettinger rhettinger

@python/macos-team macos-team

@python/windows-team windows-team

Assignees

@ambv ambv

Labels
CLA signed skip issue skip news
Projects
None yet
Milestone
No milestone
6 participants
@coderanger @the-knights-who-say-ni @miss-islington @bedevere-bot @ambv @terryjreedy