Skip to content

[FrameworkBundle] Update cache:clear help #42263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2021
Merged

[FrameworkBundle] Update cache:clear help #42263

merged 1 commit into from
Aug 6, 2021

Conversation

BafS
Copy link
Contributor

@BafS BafS commented Jul 26, 2021

Q A
Branch? 4.4
Bug fix? yes ? (kind-of)
New feature? no
Deprecations? no
Tickets no
License MIT

The current help is a bit confusing and does not match with what the command do (Clear and Warmup the cache.).

@@ -59,7 +59,7 @@ protected function configure()
])
->setDescription('Clear the cache')
->setHelp(<<<'EOF'
The <info>%command.name%</info> command clears the application cache for a given environment
The <info>%command.name%</info> command clears and warmup the application cache for a given environment
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lang: and warms up

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we change the class doc too ? Currently we have Clear and Warmup the cache.

@fabpot
Copy link
Member

fabpot commented Aug 6, 2021

Thank you @BafS.

@fabpot fabpot merged commit 21eae94 into symfony:4.4 Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants