Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upHHH-13152 - managed/cached entities and fetching (proposed fix) #2836
Conversation
| || influencers.hasEnabledFetchProfiles(); | ||
| if ( hasActiveInfluencers ) { | ||
| // we may need to force initialization of some of the entity's attributes | ||
| persister.initializeLazyProperties( entity, event.getSession() ); |
This comment has been minimized.
This comment has been minimized.
dreab8
Apr 17, 2019
Member
not sure but probably we can pass the RootGraphImplementor<?> or the EffectiveEntityGraph to the initializeLazyProperties, this avoids to call again session.getLoadQueryInfluencers(); and
loadQueryInfluencers.getEffectiveEntityGraph()
|
It seems really good to me |
|
Thanks Andrea.
One thing that occurred to me is that I also should be setting the
AttributeNode's graph (if one) as the effective graph for the corresponding
attribute initialization.
…On Wed, Apr 17, 2019, 5:38 AM Andrea Boriero ***@***.***> wrote:
***@***.**** approved this pull request.
It seems really good to me
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2836 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAOUE0oUl-gUxMHXeri8YJUfOO5vK6UJks5vhvm8gaJpZM4cztf2>
.
|
…inuation for sub-graphs)
|
Just pushed some changes to apply sub-graphs to the process. At the moment it only works for to-one associations within our limited sub-type sub-graph support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
sebersole commentedApr 16, 2019
Proposed fix for HHH-13152