Skip to content

/ node-postgres Public

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove double-send of ssl request packet #2086

Merged
merged 2 commits into from Jan 30, 2020
Merged

Remove double-send of ssl request packet #2086

merged 2 commits into from Jan 30, 2020

Conversation

@brianc
Copy link
Owner

@brianc brianc commented Jan 29, 2020

I missed the fact that we are already sending this. Since I don't have good test coverage for ssl which I am planning on fixing next this got missed.

I'm forcing an SSL test on travis. This will break for me locally as I don't have SSL enabled on my local test DB. Something I will also remedy.

This fixes #2085
brianc added 2 commits Jan 29, 2020
@brianc
Remove double-send of ssl request packet
f3c57d0 
I missed the fact that we are already sending this.  Since I don't have good test coverage for ssl [which I am planning on fixing next](#2009) this got missed.

I'm forcing an SSL test on travis.  This will break for me locally as I don't have SSL enabled on my local test DB. Something I will also remedy.
@brianc
Remove space 🤦
5e33ce5
@brianc brianc merged commit 5be3d95 into master Jan 30, 2020
2 checks passed
@brianc brianc deleted the bmc/fix-ssl-double-send branch Jan 30, 2020
@brianc brianc mentioned this pull request Feb 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Regression in 7.18.0 causing "unsupported frontend protocol 1234.5679: server supports 2.0 to 3.0"
1 participant
@brianc