Skip to content

/ matplotlib

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure all params are restored after reset_ticks. #20805

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Ensure all params are restored after reset_ticks. #20805

wants to merge 1 commit into from
+24 −2

Conversation

@QuLogic
Copy link
Member

@QuLogic QuLogic commented Aug 7, 2021

PR Summary

Currently, only label rotation was broken, but I set up the test to check everything.

Fixes #20791.

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • [n/a] New features are documented, with examples if plot related.
  • [n/a] Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • [n/a] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [n/a] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
@QuLogic
Ensure all params are restored after reset_ticks.
c304045 
Currently, only label rotation was broken, but I set up the test to
check everything.

Fixes #20791.
@QuLogic QuLogic added this to the v3.5.0 milestone Aug 7, 2021
@tacaswell
Copy link
Member

@tacaswell tacaswell commented Aug 9, 2021

Also seems related to #20219 ?
@QuLogic
Copy link
Member Author

@QuLogic QuLogic commented Aug 9, 2021

cla is not reset_ticks though. The latter is more of an internal convenience to make sure ticks are not stale by regenerating them. It is not supposed to change settings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
topic: ticks axis labels
Projects
None yet
Milestone
v3.5.0
Linked issues

Successfully merging this pull request may close these issues.

[Bug]: spines and ticklabels
2 participants
@QuLogic @tacaswell