Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include contribution of docs build to coverage. #11187

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

@anntzer
Copy link
Contributor

@anntzer anntzer commented May 7, 2018

PR Summary

Just giving it a try for now.

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way
@anntzer anntzer added the Build label May 7, 2018
@anntzer anntzer force-pushed the anntzer:circleci-coverage branch from b1181a0 to 0d9a303 May 7, 2018
@anntzer anntzer force-pushed the anntzer:circleci-coverage branch 3 times, most recently from a2e9d4e to d66438d May 7, 2018
@anntzer anntzer force-pushed the anntzer:circleci-coverage branch from d66438d to d30fdcf May 7, 2018
@jklymak
Copy link
Contributor

@jklymak jklymak commented May 9, 2018

Don't understand what this PR does.

@anntzer
Copy link
Contributor Author

@anntzer anntzer commented May 10, 2018

There are parts of the codebase that are not covered by the unit tests, but are still run as part of building the docs. This PR is trying to include the coverage provided by the docs build (by 1) building the docs under coverage.py, and 2) uploading the results to codecov), but apparently I'm doing something wrong...

@jklymak
Copy link
Contributor

@jklymak jklymak commented May 10, 2018

I see... Interesting idea!

@tacaswell tacaswell added this to the v3.1 milestone Aug 27, 2018
@tacaswell tacaswell modified the milestones: v3.1.0, v3.2.0 Feb 24, 2019
@tacaswell
Copy link
Member

@tacaswell tacaswell commented Feb 24, 2019

punting to 3.2 as this is instrumentation and not yet working.

@tacaswell tacaswell modified the milestones: v3.2.0, v3.3.0 Aug 27, 2019
@tacaswell tacaswell modified the milestones: v3.3.0, v3.4.0 May 13, 2020
@jklymak jklymak marked this pull request as draft Jul 23, 2020
@QuLogic QuLogic modified the milestones: v3.4.0, v3.5.0 Jan 21, 2021
@tacaswell tacaswell modified the milestones: v3.5.0, v3.6.0 Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants