Implement Font-Fallback for Agg backend #20740
Open
Conversation
To actually trigger this workflow, I'll push similar commits similar to #20549.. Also, there's a lot of print/debug statements throughout, I'll remove them once this moves ahead.. |
9aee34b
to
9fabbc7
7 tasks
EDIT: I've merged the FT2Font changes together for both PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
PR Summary
This PR modifies the internal structure of
FT2Font
(the interface between fonts and Matplotlib) in favor of implementing Font Fallback for the Agg backend.It builds on the previous PR: #20549, which was the 'first-step', i.e., "parsing multiple families".. this PR implements using those families for font fallback.
This would help us in multi-language support, for example (Previous / After):
^the fonts are chosen such that the difference is visually noticeable.
Here's the script:
Fixes #18883, #15260
PR Checklist
pytest
passes).flake8
on changed files to check).flake8-docstrings
and runflake8 --docstring-convention=all
).doc/users/next_whats_new/
(follow instructions in README.rst there).doc/api/next_api_changes/
(follow instructions in README.rst there).