Skip to content

/ matplotlib Public

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TST/MNT: deprecate unused fixture #20795

Merged
merged 1 commit into from Aug 6, 2021
Merged

TST/MNT: deprecate unused fixture #20795

merged 1 commit into from Aug 6, 2021
+6 −2

Conversation

@tacaswell
Copy link
Member

@tacaswell tacaswell commented Aug 5, 2021

This is left over from an early pass at nose -> pytest conversion

PR Summary

PR Checklist

  • [N/A] Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • [N/A] New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
@tacaswell tacaswell added this to the v3.6.0 milestone Aug 5, 2021
@tacaswell
TST/MNT: deprecate unused fixture
8385d46 
This is left over from an early pass at nose -> pytest conversion
@tacaswell tacaswell force-pushed the mnt_deprecate_unused_fixture branch from febcaad to 8385d46 Aug 5, 2021
@tacaswell
Copy link
Member Author

@tacaswell tacaswell commented Aug 5, 2021 •
edited

I found this while trying to debug the coverage decrease in #19255

QuLogic
QuLogic approved these changes Aug 6, 2021
View changes
@QuLogic
Copy link
Member

@QuLogic QuLogic commented Aug 6, 2021

The deprecation says 3.5, but the milestone says 3.6?

@tacaswell tacaswell removed this from the v3.6.0 milestone Aug 6, 2021
@tacaswell tacaswell added this to the v3.5.0 milestone Aug 6, 2021
@tacaswell
Copy link
Member Author

@tacaswell tacaswell commented Aug 6, 2021

The deprecation says 3.5, but the milestone says 3.6?

User error on my part in milestoning 🐑

@jklymak jklymak merged commit d958497 into matplotlib:master Aug 6, 2021
27 checks passed
@tacaswell tacaswell deleted the mnt_deprecate_unused_fixture branch Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic

@timhoffm timhoffm

Assignees
No one assigned
Labels
API: changes
Projects
None yet
Milestone
v3.5.0
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@tacaswell @QuLogic @timhoffm @jklymak