Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw exception or provide info message when route's component is null #2038

Open
mortyccp opened this issue Jan 31, 2018 · 6 comments
Open

Throw exception or provide info message when route's component is null #2038

mortyccp opened this issue Jan 31, 2018 · 6 comments
Labels
contribution welcome feature request good first issue
Projects
Longterm

Comments

@mortyccp
Copy link

@mortyccp mortyccp commented Jan 31, 2018

What problem does this feature solve?

Currently, route's component can be null and it give no information and error. Provide information or raising error can help users to catch they have some import issues when they use

import * as components from './components'

export default [
  {
    path: '/accounts',
    component: components.AccountsListView,
    name: 'accountsListView'
  },
  {
    path: '/accounts/create',
    component: components.CreateEditAccounts,
    name: 'createAccounts'
  }
]

So if components.CreateEditAccounts is null, they will know what went wrong easier.

What does the proposed API look like?

Raise error when component is null or log info message.
@posva
Copy link
Member

@posva posva commented Jan 31, 2018

for anybody picking this up: make sure to check it only in dev mode

@AlbertLucianto AlbertLucianto mentioned this issue Feb 2, 2018
Open
@posva posva mentioned this issue Feb 8, 2018
Closed
@serge1peshcoff
Copy link

@serge1peshcoff serge1peshcoff commented Feb 8, 2018

I will try to implement this the next week if nobody would be faster than me

@posva
Copy link
Member

@posva posva commented Feb 8, 2018

There's already a pr 😉

@posva posva added the has PR label Mar 26, 2019
@posva
Copy link
Member

@posva posva commented Mar 26, 2019

Note to myself, this could be solved through typings

@posva posva added this to Doable or in refactor (low prio, low complex) in Longterm Mar 26, 2019
@posva posva mentioned this issue Aug 25, 2019
Closed
@deckar01
Copy link

@deckar01 deckar01 commented Aug 26, 2019

This issue also produces unexpected behavior when routes without components have child routes. See #2908.

@posva The MR for this is 18 months old. Can we close that and remove the has PR label?

@posva posva removed the has PR label May 26, 2020
@amitkeinan9
Copy link

@amitkeinan9 amitkeinan9 commented Jan 17, 2021

I see that no one had touched this issue since March. May I try?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contribution welcome feature request good first issue
Projects
Longterm
Doable or in refactor (low prio, low ...
Milestone
No milestone
Development

No branches or pull requests
5 participants
@posva @serge1peshcoff @deckar01 @mortyccp @amitkeinan9