Skip to content

/ rclone

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve corrupted on transfer: MD5 hash differ message #5268

Open
glensc opened this issue Apr 22, 2021 · 4 comments
Open

Improve corrupted on transfer: MD5 hash differ message #5268

glensc opened this issue Apr 22, 2021 · 4 comments
Labels
enhancement good first issue UX

Comments

@glensc
Copy link
Contributor

@glensc glensc commented Apr 22, 2021

What is your current rclone version (output from rclone version)?

v1.55.0

What problem are you are trying to solve?

Help user with the error.

How do you think rclone should be changed to solve that?

2021/04/22 22:27:01 ERROR : Google Photos/2016/10/VID_20161015_234919.mp4: corrupted on transfer: MD5 hash differ "a9f23639b60607a0571312a999e6ac84" vs "910b8923f1d418425ccc5d52dbac7cea"

It's much better if it said:

MD5 corrupted on transfer: expected a9f23639b60607a0571312a999e6ac84, got 910b8923f1d418425ccc5d52dbac7cea.

Or

MD5 corrupted on transfer: expected 910b8923f1d418425ccc5d52dbac7cea, got a9f23639b60607a0571312a999e6ac84.

as you can see, this makes it distinguishable, which one is the wrong one.
@glensc
Copy link
Contributor Author

@glensc glensc commented Apr 22, 2021

NOTE for self:

  • as for the problem, the problematic file downloaded from gdrive web was with 910b8923f1d418425ccc5d52dbac7cea checksum, so used --ignore-checksum flag once for rclone copy and the error is not appearing no more for me.

refs:
@ncw
Copy link
Member

@ncw ncw commented Apr 25, 2021

I'd probably prefer to use the words source and destination rather than want and got since we don't actually know which one is correct. Would that be OK? Or we could put the names of the filesytems in brackets for ultimate clarity

This would be an easy fix if you want to send a pull request?
@glensc
Copy link
Contributor Author

@glensc glensc commented Apr 25, 2021

@ncw I don't really care about the wording as long as they are clear. I also don't know about the internals to argue on the topic.

Thanks for the offer, I don't want to send a PR. You can take all the credits :D
@glensc
Copy link
Contributor Author

@glensc glensc commented Apr 25, 2021

What is useful to the user is to give them hint to use --ignore-checksum. Perhaps have section in the documentation about it with caveats, problems and what not. and print link to that section in command output.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue UX
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@glensc @ncw @ivandeex