Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add .DS_store on ignore #27711

Merged
merged 2 commits into from Aug 11, 2021
Merged

Add .DS_store on ignore #27711

merged 2 commits into from Aug 11, 2021

Conversation

@180909
Copy link
Contributor

@180909 180909 commented Aug 10, 2021

No description provided.

@180909
add .DS_store on ignore
ec71f8a
@the-knights-who-say-ni
Copy link

@the-knights-who-say-ni the-knights-who-say-ni commented Aug 10, 2021

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@180909

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@ambv
ambv reviewed Aug 10, 2021
View changes
.gitignore Outdated Show resolved Hide resolved
@180909 @ambv
Update .gitignore
295dd60 
Co-authored-by: Łukasz Langa <lukasz@langa.pl>
@ambv ambv merged commit 1841c70 into python:main Aug 11, 2021
12 checks passed
12 checks passed
@github-actions
Check for source changes
Details
@github-actions
Check if generated files are up to date
Details
@github-actions
Windows (x86)
Details
@github-actions
Windows (x64)
Details
@github-actions
macOS
Details
@github-actions
Ubuntu
Details
@github-actions
Ubuntu SSL tests with OpenSSL
Details
@github-actions
Address sanitizer Address sanitizer
Details
Azure Pipelines PR #20210811.1 succeeded
Details
@travis-ci
Travis CI - Pull Request Build Passed
Details
@bedevere-bot
bedevere/issue-number Issue report skipped
@bedevere-bot
bedevere/news "skip news" label found
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Aug 11, 2021

Thanks @180909 for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Aug 11, 2021

GH-27723 is a backport of this pull request to the 3.10 branch.

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Aug 11, 2021

GH-27724 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit to miss-islington/cpython that referenced this pull request Aug 11, 2021
@180909 @miss-islington
Add .DS_Store on ignore (pythonGH-27711)
43c276c 
Co-authored-by: Łukasz Langa <lukasz@langa.pl>
(cherry picked from commit 1841c70)

Co-authored-by: 180909 <wjh180909@gmail.com>
miss-islington added a commit to miss-islington/cpython that referenced this pull request Aug 11, 2021
@180909 @miss-islington
Add .DS_Store on ignore (pythonGH-27711)
92c3da0 
Co-authored-by: Łukasz Langa <lukasz@langa.pl>
(cherry picked from commit 1841c70)

Co-authored-by: 180909 <wjh180909@gmail.com>
ambv pushed a commit that referenced this pull request Aug 11, 2021
@miss-islington @180909
Add .DS_Store on ignore (GH-27711) (GH-27724)
8c93a63 
Co-authored-by: Łukasz Langa <lukasz@langa.pl>
(cherry picked from commit 1841c70)

Co-authored-by: 180909 <wjh180909@gmail.com>
@180909 180909 deleted the 180909:add-DS_store-on-ignore branch Aug 11, 2021
@180909 180909 restored the 180909:add-DS_store-on-ignore branch Aug 11, 2021
@180909 180909 deleted the 180909:add-DS_store-on-ignore branch Aug 11, 2021
@180909 180909 restored the 180909:add-DS_store-on-ignore branch Aug 11, 2021
ambv pushed a commit that referenced this pull request Aug 11, 2021
@miss-islington @180909
Add .DS_Store on ignore (GH-27711) (GH-27723)
e8a43ef 
Co-authored-by: Łukasz Langa <lukasz@langa.pl>
(cherry picked from commit 1841c70)

Co-authored-by: 180909 <wjh180909@gmail.com>
JuniorJPDJ added a commit to JuniorJPDJ/cpython that referenced this pull request Aug 12, 2021
@180909 @ambv @JuniorJPDJ
Add .DS_Store on ignore (pythonGH-27711)
4225c9e 
Co-authored-by: Łukasz Langa <lukasz@langa.pl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ambv ambv

Assignees
No one assigned
Labels
CLA not signed skip issue skip news
Projects
None yet
Milestone
No milestone
5 participants
@180909 @the-knights-who-say-ni @miss-islington @bedevere-bot @ambv