Clarify goals of AbstractController #42422
Open
+9
−1
Conversation
|
Make sense |
| @@ -50,7 +50,7 @@ | |||
| use Twig\Environment; | |||
|
|
|||
| /** | |||
| * Provides common features needed in controllers. | |||
| * Provides shortcuts for HTTP related-features in controllers. | |||
OskarStark
Aug 8, 2021
Contributor
Suggested change
| * Provides shortcuts for HTTP related-features in controllers. | |
| * Provides shortcuts for HTTP-related features in controllers. |
|
i'll assume the local service refs (eg. getSubscribedServices) remain available in a protected container like till forever :) UPGRADE file should be updated :') |
|
Makes sense, although |
|
Makes sense, but Messenger is one of the recently added components in the AbstractControllers, I believe it's not only HTTP related feature, should this part be flagged as deprecated and moved out from the AbstractController? |
fabpot
force-pushed the
fabpot:abstract-controller-clarification
branch
from
14d7f9c
to
b182498
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
AbstractController should only be about HTTP-related features and we should not encourage developers to put some other logic in controllers. See #42418 for a discussion about it.