Skip to content

Add Estonian (et) translations #42485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 13, 2021
Merged

Add Estonian (et) translations #42485

merged 1 commit into from
Aug 13, 2021

Conversation

hluup
Copy link
Contributor

@hluup hluup commented Aug 11, 2021 •
edited
Loading

Q A
Branch? 4.4
Bug fix? no
New feature? no
Deprecations? no
Tickets Fix #38738
License MIT
Doc PR N/A

Added new translations and made few small updates to couple of existing ones.

@carsonbot
Copy link

Hey!

To help keep things organized, we don't allow "Draft" pull requests. Could you please click the "ready for review" button or close this PR and open a new one when you are done?

Note that a pull request does not have to be "perfect" or "ready for merge" when you first open it. We just want it to be ready for a first review.

Cheers!

Carsonbot

@hluup hluup mentioned this pull request Aug 11, 2021
Closed
@hluup
Copy link
Contributor Author

hluup commented Aug 11, 2021

Closing as requested.

@hluup hluup closed this Aug 11, 2021
@wouterj
Copy link
Member

wouterj commented Aug 11, 2021

Hi @hluup. Thanks for this contribution. I think it's OK to leave this open, but without the draft status.
It's already great to have some messages translated already, you don't have to do all of them in a single PR.

@wouterj wouterj reopened this Aug 11, 2021
@wouterj wouterj marked this pull request as ready for review August 11, 2021 17:52
@carsonbot carsonbot added this to the 4.4 milestone Aug 11, 2021
@wouterj wouterj changed the title Add Estonian (et) translations [WIP] Add Estonian (et) translations Aug 11, 2021
@Nyholm
Copy link
Member

Nyholm commented Aug 11, 2021

Awesome!
Thank you @hluup for working on this.

@hluup hluup requested review from xabbuh and yceruto as code owners August 13, 2021 11:35
@hluup
Copy link
Contributor Author

hluup commented Aug 13, 2021

Everything should be translated now.

@hluup hluup changed the title [WIP] Add Estonian (et) translations Add Estonian (et) translations Aug 13, 2021
javiereguiluz
javiereguiluz approved these changes Aug 13, 2021
View reviewed changes
Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Validated with Google Translate

Thanks Hendrik!

@fabpot
Copy link
Member

fabpot commented Aug 13, 2021

Thank you @hluup.

@fabpot fabpot merged commit 7151ffe into symfony:4.4 Aug 13, 2021
@hluup hluup deleted the et_translations branch August 13, 2021 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@javiereguiluz javiereguiluz javiereguiluz approved these changes

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

@wouterj wouterj Awaiting requested review from wouterj wouterj is a code owner

@xabbuh xabbuh Awaiting requested review from xabbuh xabbuh is a code owner

@yceruto yceruto Awaiting requested review from yceruto yceruto is a code owner

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
6 participants
@hluup @carsonbot @wouterj @Nyholm @fabpot @javiereguiluz