Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(router): ensure check for match options is compatible with proper… #43086

Closed
wants to merge 1 commit into from
Closed

fix(router): ensure check for match options is compatible with proper… #43086

wants to merge 1 commit into from

Conversation

@atscott
Copy link
Contributor

@atscott atscott commented Aug 9, 2021

…ty renaming

After renaming, 'paths' is not in routerLinkOptions since it's been renamed.
@google-cla google-cla bot added the cla: yes label Aug 9, 2021
@google-cla google-cla bot added the cla: yes label Aug 9, 2021
@ngbot ngbot bot added this to the Backlog milestone Aug 9, 2021
@ngbot ngbot bot added this to the Backlog milestone Aug 9, 2021
@atscott
Copy link
Contributor Author

@atscott atscott commented Aug 9, 2021

presubmit

AndrewKushnir
AndrewKushnir approved these changes Aug 9, 2021
View changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

LGTM 👍

One nit: may be add a quick comment on why this change was made and that further refactoring might affect Closure compiler-generated code (so we don't break it accidentally).

@atscott
fix(router): ensure check for match options is compatible with proper…
4f178ef 
…ty renaming

After renaming, 'paths' is not in routerLinkOptions since it's been renamed.
AndrewKushnir added a commit that referenced this issue Aug 9, 2021
@atscott @AndrewKushnir
fix(router): ensure check for match options is compatible with proper…
dd3abdb 
…ty renaming (#43086)

After renaming, 'paths' is not in routerLinkOptions since it's been renamed.

PR Close #43086
@angular-automatic-lock-bot
Copy link

@angular-automatic-lock-bot angular-automatic-lock-bot bot commented Sep 9, 2021

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2021
TeriGlover added a commit to TeriGlover/angular that referenced this issue Sep 16, 2021
@atscott @TeriGlover
fix(router): ensure check for match options is compatible with proper…
4f62799 
…ty renaming (angular#43086)

After renaming, 'paths' is not in routerLinkOptions since it's been renamed.

PR Close angular#43086
TeriGlover added a commit to TeriGlover/angular that referenced this issue Sep 22, 2021
@atscott @TeriGlover
fix(router): ensure check for match options is compatible with proper…
dfb8c8c 
…ty renaming (angular#43086)

After renaming, 'paths' is not in routerLinkOptions since it's been renamed.

PR Close angular#43086
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AndrewKushnir AndrewKushnir

Assignees
No one assigned
Labels
action: merge cla: yes comp: router target: patch
Projects
None yet
Milestone
Backlog
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@atscott @AndrewKushnir