api: add GET /api/v1/{owner}/{repo}/commits endpoint
#6574
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @unknwon, Is there any way I can get a review/approval for this PR? Best, |
unknwon
requested changes
Sep 23, 2021
unknwon
added
status: needs followup
Thank you for the review! The comments should be addressed 👍 |
unknwon
changed the title
GET /api/v1/{owner}/{repo}/commits endpoint
Codecov Report
@@ Coverage Diff @@
## main #6574 +/- ##
=====================================
Coverage 8.82% 8.82%
=====================================
Files 96 96
Lines 13194 13194
=====================================
Hits 1165 1165
Misses 11867 11867
Partials 162 162 |
|
The lint is failing for things that are not related to this PR, I will merge and fix it in another commit. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request targets issue #6573.
It provides a new API endpoint:
/api/v1/repos/{org}/{repo}/commits?pageSize=<int>with a default page size of 30 commits (the same as the UI).This implementation currently only focuses on the main/master branch of the repository, and does not provide the ability to return commit history for other branches.
GetAllCommitsandGetSingleCommit, I decided to pull the code out into a helper function,gitCommitToAPICommit(commit, context).