Skip to content

Improvements for Pregel memory-mapped files #14637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 17, 2021
Merged

Improvements for Pregel memory-mapped files #14637

merged 4 commits into from
Aug 17, 2021

Conversation

jsteemann
Copy link
Contributor

Scope & Purpose

Backport of #14636

  • When creating Pregel memory-mapped files, create them with O_TMPFILE attribute on Linux and MacOS so that files are guaranteed to vanish even if a process dies.
  • 💩 Bugfix (requires CHANGELOG entry)
  • 🍕 New feature (requires CHANGELOG entry, feature documentation and release notes)
  • 🔥 Performance improvement
  • 🔨 Refactoring/simplification
  • 📖 CHANGELOG entry made

Backports:

  • No backports required

Testing & Verification

  • The behavior in this PR was manually tested
  • This change is already covered by existing tests, such as shell_client, gtest.

@jsteemann
Improvements for Pregel memory-mapped files
4d519ba 
* When creating Pregel memory-mapped files, create them with O_TMPFILE
  attribute on Linux and MacOS so that files are guaranteed to vanish
  even if a process dies.
@jsteemann jsteemann added this to the 3.8 milestone Aug 13, 2021
@jsteemann jsteemann requested review from kvahed and mpoeter August 13, 2021 21:01
@jsteemann jsteemann mentioned this pull request Aug 13, 2021
Merged
8 tasks
neunhoef
neunhoef approved these changes Aug 16, 2021
View reviewed changes
Copy link
Member

@neunhoef neunhoef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kvahed
kvahed approved these changes Aug 16, 2021
View reviewed changes
Copy link
Contributor

@kvahed kvahed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KVS85 KVS85 added the 3 Pregel Graph processing label Aug 17, 2021
@KVS85 KVS85 merged commit 1216e89 into 3.8 Aug 17, 2021
@KVS85 KVS85 deleted the bug-fix-3.8/pregel-improvements branch August 17, 2021 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvahed kvahed kvahed approved these changes

@neunhoef neunhoef neunhoef approved these changes

@mpoeter mpoeter mpoeter approved these changes

Assignees

@jsteemann jsteemann

Labels
3 Pregel Graph processing 9 Ready to Merge
Projects
None yet
Milestone
3.8
Development

Successfully merging this pull request may close these issues.
5 participants
@jsteemann @kvahed @neunhoef @mpoeter @KVS85