Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dialog auth #913

Open
wants to merge 2 commits into
base: master
from
Open

dialog auth #913

wants to merge 2 commits into from

Conversation

@tpetr
Copy link

@tpetr tpetr commented Jan 1, 2019

Description

This PR adds support for the dialog authentication plugin. I cut some corners by leaving the DialogFunc() implementation to the user instead of attempting to load a shared library, but I think this is a good enough start. If DialogFunc() is not implemented, we simply use whatever password is defined in the DSN.

Related to #803.

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary
  • Added myself / the copyright holder to the AUTHORS file
tpetr added 2 commits Jan 1, 2019
@@ -60,6 +60,8 @@ type Config struct {
MultiStatements bool // Allow multiple statements in one query
ParseTime bool // Parse time values to time.Time
RejectReadOnly bool // Reject read-only connections

DialogFunc func(byte, string) (string, error) // Optional dialog auth implementation

This comment has been minimized.

@julienschmidt

julienschmidt Mar 8, 2019
Member

This should document what the default behavior is if no dialog auth implementation is provided

@@ -133,7 +133,7 @@ Valid Values: true, false
Default: false
```

`allowCleartextPasswords=true` allows using the [cleartext client side plugin](http://dev.mysql.com/doc/en/cleartext-authentication-plugin.html) if required by an account, such as one defined with the [PAM authentication plugin](http://dev.mysql.com/doc/en/pam-authentication-plugin.html). Sending passwords in clear text may be a security problem in some configurations. To avoid problems if there is any possibility that the password would be intercepted, clients should connect to MySQL Server using a method that protects the password. Possibilities include [TLS / SSL](#tls), IPsec, or a private network.
`allowCleartextPasswords=true` allows using the [cleartext client side plugin](http://dev.mysql.com/doc/en/cleartext-authentication-plugin.html) or [dialog plugin](https://mariadb.com/kb/en/library/development-pluggable-authentication/#dialog-client-plugin) if required by an account, such as one defined with the [PAM authentication plugin](http://dev.mysql.com/doc/en/pam-authentication-plugin.html). Sending passwords in clear text may be a security problem in some configurations. To avoid problems if there is any possibility that the password would be intercepted, clients should connect to MySQL Server using a method that protects the password. Possibilities include [TLS / SSL](#tls), IPsec, or a private network.

This comment has been minimized.

@cbandy

cbandy Apr 4, 2019

The links to dev.mysql.com appear broken to me. Might you be able to fix these?

For example, http://dev.mysql.com/doc/en/cleartext-authentication-plugin.html
redirects me to https://dev.mysql.com/doc/refman/8.0/en/cleartext-authentication-plugin.html
which returns 404 and Page Not Found.

@julienschmidt julienschmidt modified the milestones: v1.5.0, v1.6.0 Apr 24, 2019
@dolmen
Copy link
Contributor

@dolmen dolmen commented Jun 1, 2020

Extending the mysql.Config for any authentication use case should stop. In this package we should keep the core functionality.

If people want to use an alternate way to build the DSN, they can wrap the mysql.Driver and build their own driver.Driver. See github.com/dolmen-go/mylogin-driver as an example.

@pierresouchay
Copy link

@pierresouchay pierresouchay commented Aug 20, 2020

@dolmen What about this patch? Is there a plan to support PAM auth?
@tpetr Are you interested into rebasing this patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.