Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create CODE_OF_CONDUCT.md #15287

Merged
merged 1 commit into from Oct 23, 2019
Merged

Create CODE_OF_CONDUCT.md #15287

merged 1 commit into from Oct 23, 2019

Conversation

@Rick-Anderson
Copy link
Contributor

@Rick-Anderson Rick-Anderson commented Oct 23, 2019

Copy/paste of https://github.com/dotnet/docs/blob/master/CODE_OF_CONDUCT.md

That's a long and difficult to parse sentence. Can we break it up?

Fixes #15289

@Rick-Anderson Rick-Anderson requested a review from mairaw Oct 23, 2019
@mairaw
Copy link
Contributor

@mairaw mairaw commented Oct 23, 2019

That's the standard used in the .NET repos: https://github.com/dotnet/corefx/blob/master/CODE-OF-CONDUCT.md

@mairaw
mairaw approved these changes Oct 23, 2019
@mairaw
Copy link
Contributor

@mairaw mairaw commented Oct 23, 2019

I'd ping @jongalloway if we want to standardize on a different message for the code of conduct file.

@Rick-Anderson
Copy link
Contributor Author

@Rick-Anderson Rick-Anderson commented Oct 23, 2019

I just want to use the standard for our org. But that sentence is difficult to understand and I'm sure it MT terribly.

@mairaw
Copy link
Contributor

@mairaw mairaw commented Oct 23, 2019

I don't disagree with you. Here's what MicrosoftDocs uses:
https://github.com/MicrosoftDocs/azure-docs/blob/master/CODE_OF_CONDUCT.md

@JasonCard I don't see that file in the loc repos.

@Rick-Anderson
Copy link
Contributor Author

@Rick-Anderson Rick-Anderson commented Oct 23, 2019

@JasonCard I don't see that file in the loc repos.

Is that because it's missing from this repo?

@Rick-Anderson
Copy link
Contributor Author

@Rick-Anderson Rick-Anderson commented Oct 23, 2019

Here's what MicrosoftDocs uses:
https://github.com/MicrosoftDocs/azure-docs/blob/master/CODE_OF_CONDUCT.md

Much better.

Merging this for now. Hopefully we can standardize on https://github.com/MicrosoftDocs/azure-docs/blob/master/CODE_OF_CONDUCT.md

@Rick-Anderson Rick-Anderson merged commit 0ce5b12 into master Oct 23, 2019
6 checks passed
6 checks passed
Docs Content Validation Status: Succeeded
Details
OpenPublishing.Build Validation status: passed
Details
OpenPublishing.Build (1 of 3) Waiting for processor completed at 14:12:56 PST
OpenPublishing.Build (2 of 3) Preparing completed at 14:14:06 PST
OpenPublishing.Build (3 of 3) Building completed at 14:14:40 PST
license/cla All CLA requirements met.
@Rick-Anderson Rick-Anderson deleted the add-code-of-conduct-1 branch Oct 23, 2019
@JasonCard
Copy link
Contributor

@JasonCard JasonCard commented Oct 24, 2019

@mairaw @Rick-Anderson We were not sure if CODE_OF_CONDUCT.md should be localized or not, so it was on hold. I'll follow up on this question and get back to you.

@Rick-Anderson
Copy link
Contributor Author

@Rick-Anderson Rick-Anderson commented Oct 24, 2019

I'm not sure either. I just merged into live so you should have the english version soon. @jongalloway probably knows.

@mairaw
Copy link
Contributor

@mairaw mairaw commented Oct 24, 2019

Since you localize the contributing file, I'd probably localize this one as well.

@JasonCard
Copy link
Contributor

@JasonCard JasonCard commented Oct 24, 2019

@mairaw That's a good point, I'm going to go ahead and have the CODE_OF_CONDUCT.md localized in HT. It looks the same for .NET and ASP.NET, so once it's localized for one, then translation can be recycled. cc @Rick-Anderson

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants