Skip to content

/ sheetjs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix x-spreadsheet demo #2133

Open
reviewher opened this issue Oct 8, 2020 · 2 comments
Open

fix x-spreadsheet demo #2133

reviewher opened this issue Oct 8, 2020 · 2 comments
Labels
good first issue

Comments

@reviewher
Copy link
Contributor

@reviewher reviewher commented Oct 8, 2020

https://oss.sheetjs.com/sheetjs/x-spreadsheet.html

Uncaught ReferenceError: x is not defined
at x-spreadsheet.html:54
@Denisqo
Copy link

@Denisqo Denisqo commented Oct 8, 2020

Hello,

I would like to work on this issue.
@reviewher
Copy link
Contributor Author

@reviewher reviewher commented Oct 8, 2020

Awesome! https://github.com/SheetJS/sheetjs/blob/gh-pages/x-spreadsheet.html the file is x-spreadsheet.html in the gh-pages branch.

The current code:

var xspr = x.spreadsheet(HTMLOUT);

Based on https://github.com/myliang/x-spreadsheet#cdn I think the fix is just

var xspr = x_spreadsheet(HTMLOUT);

To test this, make the change and see if you get an error in the JS console when you open the page.
lokiiarora pushed a commit to lokiiarora/sheetjs that referenced this issue Oct 10, 2020
Lokesh Lokesh
fix SheetJS#2133
Loading status checks…
83f7c4e
@lokiiarora lokiiarora mentioned this issue Oct 10, 2020
Open
@michaeltomasik michaeltomasik mentioned this issue Oct 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@reviewher @Denisqo