Update _dendrogram.py #3062
Closed
Update _dendrogram.py #3062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cleaning
|
Thanks for the contribution! Just to confirm: is this meant to change any behaviour or just be cleaner? |
|
Cleaner stuff. Can you please also remove the computation of linkage and
distance from your class. We apply proprietary methods to estimate the
linkage. Makes your code complex unnecessary. Kind regards
Thomas
…On Thu, 4 Feb 2021 at 16:13, Nicolas Kruchten ***@***.***> wrote:
Thanks for the contribution! Just to confirm: is this meant to change any
behaviour or just be cleaner?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3062 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAPTQ7ZURI3ANIXVYA25LGLS5KFOBANCNFSM4XCINNCA>
.
|
|
This dendrogram figure factory is basically legacy code at this point that we don't really maintain and has no tests associated with it. If you have specific needs for linkage computation, I would recommend you fork this code into your project :) |
|
Sure, I have copied the code into my repo. Unfortunately, such acts make
moving away from matplotlib risky and tedious.
…On Thu, 4 Feb 2021 at 20:23, Nicolas Kruchten ***@***.***> wrote:
This dendrogram figure factory is basically legacy code at this point that
we don't really maintain and has no tests associated with it. If you have
specific needs for linkage computation, I would recommend you fork this
code into your project :)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3062 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAPTQ76H3NQIR6OPTUUJCDTS5LCZJANCNFSM4XCINNCA>
.
--
Dr. Thomas Schmelzer
*post: Abu Dhabi EDITION*
Marina - Al Bateen - Abu Dhabi, United Arab Emirates
*mobile:* +971 54 56 09 556
*skype: *thomas.schmelzer
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cleaning