Skip to content

/ vue Public

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong definition of the type AsyncComponentFactory #10252

Open
Maorey opened this issue Jul 10, 2019 · 5 comments · May be fixed by #10253
Open

Wrong definition of the type AsyncComponentFactory #10252

Maorey opened this issue Jul 10, 2019 · 5 comments · May be fixed by #10253
Labels
good first issue has PR typescript

Comments

@Maorey
Copy link

@Maorey Maorey commented Jul 10, 2019

Version

2.6.10

Reproduction link

https://github.com/vuejs/vue

Steps to reproduce

  1. compare the AsyncComponentFactory definition with the document

What is expected?

attribute 'component' should be a promise

What is actually happening?

AsyncComponentPromise

I'm looking forward to your solution to this issue
@posva
Copy link
Member

@posva posva commented Jul 10, 2019

It seems the type should be Promise<Component | EsModuleComponent>

@NataliaTepluhina NataliaTepluhina linked a pull request that will close this issue Jul 10, 2019
Open
13 tasks
@posva posva added the has PR label Jul 10, 2019
NataliaTepluhina added a commit to NataliaTepluhina/vue that referenced this issue Jul 14, 2019
@NataliaTepluhina
fix: add test for AsyncComponentFactory
3be9e28 
Close vuejs#10252
NataliaTepluhina added a commit to NataliaTepluhina/vue that referenced this issue Jul 14, 2019
@NataliaTepluhina
fix: fixed a type for AsyncComponentFactory component
f75a39d 
Close vuejs#10252
@Maorey Maorey closed this Jul 22, 2019
@posva posva reopened this Jul 22, 2019
@harshajayaweeraXHJ
Copy link

@harshajayaweeraXHJ harshajayaweeraXHJ commented Aug 31, 2019

Is this issue still available

@jvik
Copy link

@jvik jvik commented Oct 2, 2019

@harshajayaweeraXHJ The issue already has a PR

@juzhiyuan
Copy link

@juzhiyuan juzhiyuan commented Aug 3, 2021

Any update here?

@tulpauction001

This comment was marked as off-topic.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue has PR typescript
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

fix: changed a type for AsyncComponentFactory component(fix #10252)
7 participants
@posva @juzhiyuan @harshajayaweeraXHJ @jvik @Maorey @tulpauction001 and others