Skip to content

/ python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add e2e test for strategic merge patch #951

Open
roycaihw opened this issue Sep 10, 2019 · 6 comments
Open

Add e2e test for strategic merge patch #951

roycaihw opened this issue Sep 10, 2019 · 6 comments
Assignees
@palnabarun
Labels
good first issue help wanted kind/feature

Comments

@roycaihw
Copy link
Member

@roycaihw roycaihw commented Sep 10, 2019

Add a test sending (e.g. config map) patches through the same API using:

make sure the API client is able to set the content type properly according to the request body, and the patches are applied successfully.

ref: #931 (comment)
@roycaihw roycaihw mentioned this issue Sep 10, 2019
Merged
@palnabarun
Copy link
Member

@palnabarun palnabarun commented Oct 6, 2019

I want to give a shot at this. :)

/assign
@fejta-bot
Copy link

@fejta-bot fejta-bot commented Jan 4, 2020

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale
@palnabarun
Copy link
Member

@palnabarun palnabarun commented Jan 5, 2020

/remove-lifecycle stale
@roycaihw
Copy link
Member Author

@roycaihw roycaihw commented Mar 12, 2020

Examples of using these patches:

strategic merge patch: #641 (comment)
json patch: #641 (comment)

We can have one test sending multiple kinds of patch and make sure nothing fails, or two tests doing the same thing but using different kinds of patch.
@mdgreenwald mdgreenwald mentioned this issue May 19, 2020
Open
@fejta-bot
Copy link

@fejta-bot fejta-bot commented Jun 10, 2020

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale
@fejta-bot
Copy link

@fejta-bot fejta-bot commented Jul 10, 2020

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@palnabarun palnabarun

Labels
good first issue help wanted kind/feature
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
@roycaihw @palnabarun @k8s-ci-robot @fejta-bot
You can’t perform that action at this time.