Skip to content

/ Babylon.js Public

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add serializer support for KHR_Materials_Specular #8968

Open
Drigax opened this issue Sep 15, 2020 · 2 comments
Open

Add serializer support for KHR_Materials_Specular #8968

Drigax opened this issue Sep 15, 2020 · 2 comments
Labels
enhancement exporters good first issue help wanted
Milestone
Future

Comments

@Drigax
Copy link
Contributor

@Drigax Drigax commented Sep 15, 2020 •
edited

See forum post: https://forum.babylonjs.com/t/babylon-editor-export-texture-scaling/12723/26

Reproducible via playground: https://playground.babylonjs.com/#DHZKGW#7

Currently when we export specularGlossiness PBRMaterials via _GLTFMaterialExporter._convertSpecularGlossinessTexturesToMetallicRoughnessAsync

We combine albedo + glossiness textures into Base64 texture string, stripping all extension information.

This should probably be changed to bake transform information before combining the textures.
@Drigax Drigax self-assigned this Sep 15, 2020
@Drigax Drigax changed the title Texture extensions are lost when exporting SpecGloss textures Texture transform is lost when exporting SpecGloss textures Sep 15, 2020
@Drigax
Copy link
Contributor Author

@Drigax Drigax commented Sep 16, 2020

Currently we convert spec gloss to metal rough, however we probably should export glossiness factors/textures as part of our support for KHR_materials_specular

@Drigax
Copy link
Contributor Author

@Drigax Drigax commented Sep 16, 2020

Changing the title to represent this, I'd rather do this right, and have a more futureproof solution than making a half measure to fix a specific issue. Recategorizing as our support for KHR_materials_specular in our serializers.

@Drigax Drigax changed the title Texture transform is lost when exporting SpecGloss textures Add support for KHR_Materials_Specular Sep 16, 2020
@Drigax Drigax changed the title Add support for KHR_Materials_Specular Add exporter support for KHR_Materials_Specular Sep 16, 2020
@Drigax Drigax changed the title Add exporter support for KHR_Materials_Specular Add serializer support for KHR_Materials_Specular Sep 16, 2020
@thomlucc thomlucc added this to the Future milestone Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement exporters good first issue help wanted
Projects
None yet
Milestone
Future
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@Drigax @thomlucc